[4.0] Move custom fields from submenu to main menu in contact

[bembelimen]

Summary of Changes

At the moment the custom fields are in the submenu for contact. With this PR The two submenu items are moved to the main menu like in the other extensions.

Testing Instructions

• Apply patch
• Reinstall Joomla!
• Check menu items for contact
• disable/enable custom fields for contact to check display/hide

[chmst]

I have tested this item ✅ successfully on 1846d32

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23366.}

[Hackwar]

I have tested this item ✅ successfully on 1846d32

Tested successfully. We shouldd really merge in the testing sample data plugin and drop the SQL files.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23366.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23366.}

[brianteeman]

can you fix the conflicts please

[brianteeman]

@bembelimen can you fix the conflicts please and then we can get this merged

[wilsonge]

Removing rtc until conflicts are fixed. Mainly just to avoid me re-reading this PR every 2 weeks when I go through the RTC pile. Whenever they are fixed someone can mark this back as RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23366.}

[brianteeman]

@bembelimen please can you fix the conflicts

[brianteeman]

I tried to test this with the view to resolving the conflicts and submitting it as a new pr but it is not a correct PR or the code required has changed since this was created

1. disable/enable custom fields for contact to check display/hide
   This had no effect

2. The separator between contacts and fields is not rendered correctly
   <li class="divider" role="presentation"><a class="no-dropdown" href="#"><span class="sidebar-item-title"></span></a></li>
   Should be
   <li class="divider" role="presentation"><span></span></li>
   Otherwise it becomes a clickable and focusable item

[ghost]

Please resolve conflicting files so this PR can get tested at Worldwide Pizza, Bugs & Fun, October 19th

[brianteeman]

Found the reason that
disable/enable custom fields for contact to check display/hide did not work

The value for the component_id in the sql was 33 - it should be the id of the com_fields component in the extensions table which is 30

[brianteeman]

@bembelimen has obviously abandoned this important PR so if one of the sql gurus could create a new pr that would be awesome and then people will be able to create fields for com_contacts again

cc / @alikon @richard67 @Quy

[alikon]

please test #26540