[4.0] RTL: Correcting broken installation#23208
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Nov 30, 2018
Merged
Conversation
Member
Author
|
@wilsonge |
Contributor
|
Thanks JM |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #23164
Summary of Changes
The db_prefix input has to be proposed as ltr and text align to the right to be able to install Joomla when choosing an RTL language.
Otherwise we get an error
Plus a small correction of margins for the headers
Testing Instructions
See #23164 to use Persian
OR just modify installation/language/en-GB.xml to rtl 1
Before patch
Using en-GB.xml set as rtl
After patch
Joomla installs normally
@wilsonge