[mod_languages] - no need of cache fields#23174
Merged
mbabker merged 1 commit intojoomla:stagingfrom Dec 1, 2018
alikon:patch-119
Merged
[mod_languages] - no need of cache fields#23174mbabker merged 1 commit intojoomla:stagingfrom alikon:patch-119
mbabker merged 1 commit intojoomla:stagingfrom
alikon:patch-119
Conversation
Member
|
I have tested this item ✅ successfully on d25c3cd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23174. |
|
I have tested this item ✅ successfully on d25c3cd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23174. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23174. |
Contributor
|
Sorry to be late to the party, but why were this fields removed? This one was different from mod_syndicate, here caching worked and since by the itemid. |
Member
|
hmm. Have'nt we suggested many users to disable the cache for this module as they were getting weird results? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #23166 (comment)
Summary of Changes
removed the unsed cache fields
Testing Instructions
the module works as before
p.s
cc : @infograf768