-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Use new user instance #22697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Use new user instance #22697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have tested this item ✅ successfully on 56f7bc0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22697. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 56f7bc0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22697. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22697. |
Member
|
@SharkyKZ whats the reason for this change? |
Contributor
Author
|
It was a mistake on my part. We need to check new user access rights in this plugin but we shouldn't clear them on the global user instance as this could lead to undesirable behavior in code and other plugins that run after this one. |
Member
|
ok thx |
Member
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Create new user instance before clearing access rights cache so as not to clear it globally.
Testing Instructions
Code review.