Skip to content

Conversation

@SharkyKZ
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Create new user instance before clearing access rights cache so as not to clear it globally.

Testing Instructions

Code review.

@ghost ghost added the J3 Issue label Apr 5, 2019
@ghost ghost changed the title [plg_system_actionlogs] Use new user instance Use new user instance Apr 19, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 56f7bc0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22697.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Jul 2, 2019

I have tested this item ✅ successfully on 56f7bc0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22697.

@alikon
Copy link
Contributor

alikon commented Jul 2, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22697.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 2, 2019
@HLeithner
Copy link
Member

@SharkyKZ whats the reason for this change?

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Jul 3, 2019

It was a mistake on my part. We need to check new user access rights in this plugin but we shouldn't clear them on the global user instance as this could lead to undesirable behavior in code and other plugins that run after this one.

@HLeithner
Copy link
Member

ok thx

@HLeithner HLeithner merged commit ae06ccd into joomla:staging Jul 20, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 20, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.11 milestone Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants