Import from database dump only imports first table#22660
Import from database dump only imports first table#22660HLeithner merged 1 commit intojoomla:stagingfrom
Conversation
Import from database dump only imports first table .
ghost
added
the
|
@mbabker Shouldn't this change not be also made in the framework? It seems in the framework there is also a typo in the function name "getAlterTableql", but in the CMS (J3) there is not this typo. See here the framework: https://github.com/joomla-framework/database/blob/master/src/DatabaseImporter.php#L264 |
|
Every change here should eventually make it to the Framework package if the same issue exists in a similar block of code. That goes for all Framework packages, not just the database. |
|
@mbabker I don't dare to ask how it comes that it is different now regarding that typo I've mentioned. |
|
Someone screwed up copy/pasting something, code that never had test coverage to detect the typo in the first place, someone mistyped it when creating it, who knows. |
|
Well, I will care and make PR's against framework db package sooner or later. The typo is already fixed there in 2.0-dev, the change from this PR neither in master nor in 2.0-dev. |
|
@HLeithner The correction from this PR and the typo I've mentioned in our Glip discussion have been merged now in the framework database package in both the master branch and the 2.0-dev branch. As soon as a composer update is made to the latest version of joomla/database, these changes are in 4.0-dev branch here. I've pinged Brian to update his PR #25840 for updating dependencies. If he will not do it, I will do a PR later after his PR has been merged. An update will fetch us also other recent changes e.g. for PHP 7.4 (array curly brackets). |
|
Thanks Richard for managing this patch. |
6 participants
Import from database dump only imports first table .
Pull Request for Issue #22620.
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required