Do not distribute ajax-loader.gif#22581
Closed
PhilETaylor wants to merge 1 commit intojoomla:stagingfrom
PhilETaylor:patch-10
Closed
Do not distribute ajax-loader.gif#22581PhilETaylor wants to merge 1 commit intojoomla:stagingfrom PhilETaylor:patch-10
PhilETaylor wants to merge 1 commit intojoomla:stagingfrom
PhilETaylor:patch-10
Conversation
This is a file Joomla doesn't need to be distributing as it deletes it immediately after installing anyway Part of #22219
Member
Contributor
|
This is file is being used. The error is that it shouldnt be in the script of files to remove. |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
We still need to take it off the delete array as we have no idea if this loader graphic is being used in extensions. For 4.0 we can make sure we're only shipping one graphic. |
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a file Joomla doesn't need to be distributing as it deletes it immediately after installing anyway
Part of #22219