Skip to content

Do not distribute ajax-loader.gif#22581

Closed
PhilETaylor wants to merge 1 commit intojoomla:stagingfrom
PhilETaylor:patch-10
Closed

Do not distribute ajax-loader.gif#22581
PhilETaylor wants to merge 1 commit intojoomla:stagingfrom
PhilETaylor:patch-10

Conversation

@PhilETaylor
Copy link
Contributor

This is a file Joomla doesn't need to be distributing as it deletes it immediately after installing anyway

Part of #22219

This is a file Joomla doesn't need to be distributing as it deletes it immediately after installing anyway

Part of #22219
@infograf768
Copy link
Member

I guess this can be merged on review.
@mbabker @wilsonge

@brianteeman
Copy link
Contributor

This is file is being used. The error is that it shouldnt be in the script of files to remove.

modSampledataIconProgress = "' . JUri::root(true) . '/media/jui/img/ajax-loader.gif";

@PhilETaylor

This comment was marked as abuse.

@mbabker
Copy link
Contributor

mbabker commented Oct 15, 2018

We still need to take it off the delete array as we have no idea if this loader graphic is being used in extensions. For 4.0 we can make sure we're only shipping one graphic.

@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants