[4.0] Follow-up adding category language to getCategoryRoute()#22022
Merged
laoneo merged 2 commits intojoomla:4.0-devfrom Sep 11, 2018
Merged
[4.0] Follow-up adding category language to getCategoryRoute()#22022laoneo merged 2 commits intojoomla:4.0-devfrom
laoneo merged 2 commits intojoomla:4.0-devfrom
Conversation
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request to follow-up #21916 which has now been merged.
Summary of Changes
Adding the $language variable where missing when using getCategoryRoute()
Newsfeeds, Contact, mod_articles_categories, mod_articles_category, categories search plugin
Testing Instructions
Monolanguage: all should work as before.
Multilingual: info-block is not concerned as in #21916, but now all non menu links should work correctly for these components, modules, com_search for category name.
IMPORTANT:
One has to create a
List All Categoriesmenu item for articles as well as aList All Contact Categoriesand aList All News Feed Categoriesto cope with categories which do not have any specific menu item. This in order to get nice urls.As the modifications are quite obvious, it can be merged on review.
@Hackwar @csthomas