Skip to content

Conversation

@ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Aug 17, 2018

Pull Request for Issue #21639 .

Summary of Changes

#21615 removed some required functions and variables which killed the color variations in the switcher. This PR fixes that.

Testing Instructions

Apply PR and run node build.js --compile-ce

Check switcher colors (article edit)

Before

See #21639

After

image

Documentation Changes Required

@infograf768
Copy link
Member

infograf768 commented Aug 17, 2018

NOT for PatchTester users. Requires npm install (or node)

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 70db24f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21658.

@ghost
Copy link

ghost commented Aug 17, 2018

@infograf768 thanks for "NOT for PatchTester users. Requires npm install (or node)".

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 70db24f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21658.

@ghost
Copy link

ghost commented Aug 17, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 17, 2018
@wilsonge wilsonge merged commit b155552 into joomla:4.0-dev Aug 17, 2018
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Aug 17, 2018
@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 17, 2018
@wilsonge
Copy link
Contributor

Thanks!

@ciar4n ciar4n deleted the fix-switcher-colors branch August 17, 2018 14:41
@ciar4n
Copy link
Contributor Author

ciar4n commented Aug 17, 2018

Thanks for the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants