Skip to content

[4.0] [workflow] - notice on edit plugin #21623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2018
Merged

[4.0] [workflow] - notice on edit plugin #21623

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57542fa
[4.0] [workflow] - notice on edit plugin
alikon Aug 15, 2018
dda55a1
conservative
alikon Aug 15, 2018
d0211c2
don't kill empy lines
alikon Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions layouts/joomla/edit/global.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,10 @@
'version_note',
);

if ($displayData->get('item')->id !== null)
if (isset($displayData->get('item')->id) && ($displayData->get('item')->id !== null))
{
array_unshift($fields, 'transition');
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to kill that empty line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, simply lazy 😄

$hiddenFields = $displayData->get('hidden_fields') ?: array();

if (!$saveHistory)
Expand Down