Skip to content

[4.0] Workflow Transitions/Stages #21592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 10, 2018
Merged

[4.0] Workflow Transitions/Stages #21592

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bfc7770
[4.0] Transitions
brianteeman Aug 13, 2018
0d4dd34
[4.0] Workflow - transitions
brianteeman Aug 13, 2018
ffe7069
Merge branch '4.0-dev' into monday-stage
brianteeman Aug 13, 2018
dbfa778
cs
brianteeman Aug 13, 2018
229bde5
make the note styled consistently with similar fields
brianteeman Aug 13, 2018
702e8c2
use layout for the rigght hand side
brianteeman Aug 13, 2018
51ea31b
display the title
brianteeman Aug 13, 2018
8067c6c
add the same to stages
brianteeman Aug 19, 2018
da5d41c
oops
brianteeman Aug 19, 2018
bb8661b
Merge branch '4.0-dev' into monday-stage
brianteeman Aug 19, 2018
9b323bc
Merge branch '4.0-dev' into monday-stage
brianteeman Sep 7, 2018
18a3f12
Update default.php
brianteeman Sep 7, 2018
948cb87
escape text
brianteeman Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions administrator/components/com_workflow/Model/TransitionsModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,13 @@ public function getListQuery()

$select = $db->quoteName(
array(
't.id',
't.title',
't.from_stage_id',
't.to_stage_id',
't.published',
't.ordering',
't.id',
't.title',
't.from_stage_id',
't.to_stage_id',
't.published',
't.ordering',
't.description',
)
);

Expand Down
88 changes: 44 additions & 44 deletions administrator/components/com_workflow/forms/transition.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,49 @@
<?xml version="1.0" encoding="utf-8"?>
<form>
<fieldset addfieldprefix="Joomla\Component\Workflow\Administrator\Field">
<field
name="id"
type="text"
label="JGLOBAL_FIELD_ID_LABEL"
default="0"
class="readonly"
size="10"
readonly="true"
/>
<field
name="title"
type="text"
label="COM_WORKFLOW_FIELD_NAME_LABEL"
class="input-xxlarge input-large-text"
size="40"
required="true"
/>
<field
name="from_stage_id"
type="sql"
label="COM_WORKFLOW_FROM_STAGE"
required="true"
sql_select="id as value, title as from_stage_id"
sql_from="#__workflow_stages"
>
<option value="-1">JALL</option>
</field>
<field
name="to_stage_id"
type="sql"
label="COM_WORKFLOW_TO_STAGE"
required="true"
sql_select="id as value, title as to_stage_id"
sql_from="#__workflow_stages"
/>
<field
name="description"
type="editor"
label="COM_WORKFLOW_FIELD_DESC_LABEL"
class="input-xxlarge input-large-text"
/>
</fieldset>

<fields name="transition">
Copy link
Contributor

@wilsonge wilsonge Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we indent the fieldset here if we're squeezing in the <fields> element please

<fieldset addfieldprefix="Joomla\Component\Workflow\Administrator\Field">
<field
name="id"
type="hidden"
label="JGLOBAL_FIELD_ID_LABEL"
default="0"
class="readonly"
size="10"
readonly="true"
/>
<field
name="title"
type="text"
label="COM_WORKFLOW_FIELD_NAME_LABEL"
class="input-xxlarge input-large-text"
size="40"
required="true"
/>
<field
name="from_stage_id"
type="sql"
label="COM_WORKFLOW_FROM_STAGE"
required="true"
sql_select="id as value, title as from_stage_id"
sql_from="#__workflow_stages"
>
<option value="-1">JALL</option>
</field>
<field
name="to_stage_id"
type="sql"
label="COM_WORKFLOW_TO_STAGE"
required="true"
sql_select="id as value, title as to_stage_id"
sql_from="#__workflow_stages"
/>
<field
name="description"
type="text"
label="COM_WORKFLOW_TRANSITION_NOTE"
/>
</fieldset>
</fields>
<fieldset name="params" label="COM_WORKFLOW_PARAMS_LABEL">
<field
name="published"
Expand Down
20 changes: 3 additions & 17 deletions administrator/components/com_workflow/tmpl/transition/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,23 +35,9 @@
<?php echo HTMLHelper::_('uitab.addTab', 'myTab', 'details', Text::_('COM_WORKFLOW_DESCRIPTION')); ?>
<div class="row">
<div class="col-md-9">
<div class="control-group">
<div class="control-label">
<?php echo $this->form->getLabel('from_stage_id'); ?>
</div>
<div class="controls">
<?php echo $this->form->getInput('from_stage_id'); ?>
</div>
</div>
<div class="control-group">
<div class="control-label">
<?php echo $this->form->getLabel('to_stage_id'); ?>
</div>
<div class="controls">
<?php echo $this->form->getInput('to_stage_id'); ?>
</div>
</div>
<?php echo $this->form->getInput('description'); ?>
<?php foreach ($this->form->getGroup('transition') as $field) : ?>
<?php echo $field->renderField(); ?>
<?php endforeach; ?>
</div>
<div class="col-md-3">
<div class="card card-block card-light">
Expand Down
2 changes: 2 additions & 0 deletions administrator/components/com_workflow/tmpl/transitions/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,10 @@
<a href="<?php echo $edit; ?>" title="<?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape(addslashes($item->title)); ?>">
<?php echo $editIcon; ?><?php echo $item->title; ?>
</a>
<div class="small"><?php echo $item->description; ?></div>
<?php else: ?>
<?php echo $item->title; ?>
<div class="small"><?php echo $item->description; ?></div>
<?php endif; ?>
</th>
<td class="text-center">
Expand Down
1 change: 1 addition & 0 deletions administrator/language/en-GB/en-GB.com_workflow.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ COM_WORKFLOW_TRANSITIONS_LIST="%s Transitions List"
COM_WORKFLOW_TRANSITION_ADD="Add Transition"
COM_WORKFLOW_TRANSITION_DUPLICATE="This transition already exists."
COM_WORKFLOW_TRANSITION_EDIT="Edit Transition"
COM_WORKFLOW_TRANSITION_NOTE="Note"
COM_WORKFLOW_TRANSITION_THE_SAME_STAGE="Current stage and target stage are the same."
COM_WORKFLOW_TRASHED="Trashed"
COM_WORKFLOW_UNPUBLISHED="Unpublished"
Expand Down