[4.0] Workflow prevent trashing of used stages/workflows

administrator/components/com_content/Extension/ContentComponent.php

@@ -179,6 +179,20 @@ protected function getTableNameForSection(string $section = null)
 		return '#__content';
 	}
 
+	/**
+	 * Returns a table name for the state association
+	 *
+	 * @param   string  $section  An optional section to separate different areas in the component
+	 *
+	 * @return  string
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	public function getWorkflowTableBySection(string $section = null) : string
+	{
+		return '#__content';
+	}
+
 	/**
 	 * Method to filter transitions by given id of state.
 	 *

administrator/components/com_workflow/Model/StageModel.php

@@ -324,7 +324,7 @@ public function publish(&$pks, $value = 1)
 		{
 			foreach ($pks as $i => $pk)
 			{
-				if ($table->load(array('id' => $pk)) && $table->default)
+				if ($table->load($pk) && $table->default)
 				{
 					// Prune items that you can't change.
 					$app->enqueueMessage(Text::_('COM_WORKFLOW_MSG_DELETE_DEFAULT'), 'error');

administrator/language/en-GB/en-GB.com_workflow.ini

@@ -48,7 +48,9 @@ COM_WORKFLOW_MODIFIED_AT_DESC="Date Modified descending"
 COM_WORKFLOW_MODIFIED_DESC="Date Modified"
 COM_WORKFLOW_MODIFIED_LABEL="Date Modified"
 COM_WORKFLOW_MSG_DELETE_DEFAULT="You are trying to delete the default item."
-COM_WORKFLOW_MSG_DELETE_IS_ASSIGNED="This item is in use by the component."
+COM_WORKFLOW_MSG_DELETE_IS_DEFAULT="You can't delete the default item."
+COM_WORKFLOW_MSG_DELETE_STAGE_IS_ASSIGNED="This stage is in use by the component."
+COM_WORKFLOW_MSG_DELETE_WORKFLOW_IS_ASSIGNED="This workflow is in use by the component."
 COM_WORKFLOW_MSG_FROM_TO_STAGE="From Stage and To Stage must have different names."
 COM_WORKFLOW_MSG_WORKFLOWS_DELETE_ERROR="There was a problem while deleting the item: "
 COM_WORKFLOW_NA="N/A"

administrator/language/en-GB/en-GB.plg_content_joomla.ini

@@ -6,8 +6,6 @@
 PLG_CONTENT_JOOMLA="Content - Joomla"
 PLG_CONTENT_JOOMLA_FIELD_CHECK_CATEGORIES_DESC="Check that categories are fully empty before they are deleted."
 PLG_CONTENT_JOOMLA_FIELD_CHECK_CATEGORIES_LABEL="Check Category Deletion"
-PLG_CONTENT_JOOMLA_FIELD_CHECK_STAGES_DESC="Check that stages are not assigned to an item before they are deleted."
-PLG_CONTENT_JOOMLA_FIELD_CHECK_STAGES_LABEL="Check Stages Deletion"
 PLG_CONTENT_JOOMLA_FIELD_EMAIL_NEW_FE_DESC="Email users if 'Send email' is on when there is a new article submitted via the Frontend."
 PLG_CONTENT_JOOMLA_FIELD_EMAIL_NEW_FE_LABEL="Email on New Site Article"
 PLG_CONTENT_JOOMLA_FIELD_EMAIL_NEW_STAGE_DESC="Email users if 'Send email' is on when there is a status change of an article."

libraries/src/MVC/Model/AdminModel.php

@@ -78,6 +78,14 @@ abstract class AdminModel extends FormModel
 	 */
 	protected $event_before_save = null;
 
+	/**
+	 * The event to trigger before changing the published state of the data.
+	 *
+	 * @var    string
+	 * @since  __DEPLOY_VERSION__
+	 */
+	protected $event_before_change_state = null;
+
 	/**
 	 * The event to trigger after changing the published state of the data.
 	 *
@@ -214,6 +222,15 @@ public function __construct($config = array(), MVCFactoryInterface $factory = nu
 			$this->event_before_save = 'onContentBeforeSave';
 		}
 
+		if (isset($config['event_before_change_state']))
+		{
+			$this->event_before_change_state = $config['event_before_change_state'];
+		}
+		elseif (empty($this->event_before_change_state))
+		{
+			$this->event_before_change_state = 'onContentBeforeChangeState';
+		}
+
 		if (isset($config['event_change_state']))
 		{
 			$this->event_change_state = $config['event_change_state'];
@@ -1004,6 +1021,8 @@ public function publish(&$pks, $value = 1)
 		$table = $this->getTable();
 		$pks = (array) $pks;
 
+		$context = $this->option . '.' . $this->name;
+
 		// Include the plugins for the change of state event.
 		\JPluginHelper::importPlugin($this->events_map['change_state']);
 
@@ -1037,6 +1056,16 @@ public function publish(&$pks, $value = 1)
 			}
 		}
 
+		// Trigger the change state event.
+		$result = Factory::getApplication()->triggerEvent($this->event_before_change_state, array($context, $pks, $value));
+
+		if (in_array(false, $result, true))
+		{
+			$this->setError($table->getError());
+
+			return false;
+		}
+
 		// Attempt to change the state of the records.
 		if (!$table->publish($pks, $value, $user->get('id')))
 		{
@@ -1045,8 +1074,6 @@ public function publish(&$pks, $value = 1)
 			return false;
 		}
 
-		$context = $this->option . '.' . $this->name;
-
 		// Trigger the change state event.
 		$result = Factory::getApplication()->triggerEvent($this->event_change_state, array($context, $pks, $value));
 

libraries/src/Workflow/WorkflowServiceInterface.php

@@ -51,4 +51,15 @@ public static function updateContentState($pks, $condition): bool;
 	 * @since   4.0.0
 	 */
 	public static function getConditions($extension): array;
+
+	/**
+	 * Returns a table name for the state association
+	 *
+	 * @param   string  $section  An optional section to differ different areas in the component
+	 *
+	 * @return  string
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	public function getWorkflowTableBySection(string $section = null) : string;
 }