Skip to content

Added readmore link in the $item->description of the feed. #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 20 commits into from
Closed

Added readmore link in the $item->description of the feed. #214

wants to merge 20 commits into from

Conversation

@twentronix
Copy link

@twentronix twentronix commented May 23, 2012

No description provided.

Twentronix added 2 commits May 23, 2012 23:06
Added readmore link in the $item->description of the feed.
4a53485
Added option for feed_show_readmore. Used default=0 for backward comp…
64f683f 
…atibility.

TODO: language string translations of JGLOBAL_FEED_SHOW_READMORE_LABEL and JGLOBAL_FED_SHOW_READMORE_DESC
@infograf768
Copy link
Member

infograf768 commented May 24, 2012

Please add a tracker in the Joomla Feature Tracker on joomlacode ( http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549 )
Also, this pull is so incomplete that it cannot be tested.

* Fixed TODO: Only pull fulltext if necessary (actually, just get the…
0d51cd8 
… necessary fields).

* Used new feed_show_readmore option to allow users to include readmore in feed-items (yes/no)
* Reformated view.feed.php code
@twentronix
Copy link
Author

twentronix commented May 24, 2012

I've added some changes and options. It's working fine and in my opinion it's ready for a pull right now. Also added a tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28565. Please advice.

@twentronix
Copy link
Author

twentronix commented May 24, 2012

Test instructions (J!2.5)

1- Overwrite your J2.5 files:
https://github.com/joomla/joomla-cms/pull/214/files
2- Go to article manager in back-end Joomla.
3- Options -> Integration -> JGLOBAL_FEED_SHOW_READMORE_LABEL: Show
4- Add some articles, split them with readmore. Create menu-item of type
category. Maybe you need to use the syndication module to get the RSS feed
link.
5- Go to your RSS feed for that category with Firefox:
view-source:http://your-rss-feed.com
6- Now you can see the read more links in the descriptions. You can turn them
off with step 3.

@infograf768
Copy link
Member

infograf768 commented May 24, 2012

Corrected your patch. See joomlacode tracker. As I commented there, I see no use for the Read More.

Twentronix added 14 commits May 24, 2012 12:13
Added languagestrings for feed readmore links.
7c00fd6
Deleted JGLOBAL_FEED_READMORE="Read more »", added it by mistake, sho…
fef25e5 
…uld be renamed and removed to com_content
Added COM_CONTENT_FEED_READMORE="Read more »"
e1213f0
Added languagetag for readmore link. Reformated comments.
29cc1a4
Small adaption to languagestring JGLOBAL_FEED_SHOW_READMORE_DESC
523775b
Added $db->nameQuote to $query
a9799f9
Added $db->Quote for $row->id
8ce703c
Better coding and comments, no new functions.
80b04be
Added code for readmore link to view.feed.php of featured view.
441c8c7
Fixed fulltext in feeditem of featured feed
82bdf5b
Deleted TODO created_by_alias, works fine
019fcc7
Deleted TODO created_by_alias, works fine
336d3c9
Added <div class="feed-description">...</div> to feed description. Re…
73cb1c5 
…moved class from feed-readmore, since this is stylable via .feed-readmore a.
Bugfix missing Directory Seperators.
324ee66
wilsonge pushed a commit that referenced this pull request Jan 23, 2017
@ciar4n
Merge pull request #214 from C-Lodder/fixes
4072de4 
Fixes
wilsonge pushed a commit to wilsonge/joomla-cms that referenced this pull request May 26, 2019
@bembelimen
Merge pull request joomla#214 from joomla/redesign-icons
2977015 
Redesign dashboard icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twentronix @infograf768 @mbabker