Skip to content

[4.0] Fixed the parent item dropdown #21348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 3, 2018
Merged

[4.0] Fixed the parent item dropdown #21348

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e75c3e3
Fixed the parent item dropdown
fatmaakay Aug 1, 2018
befa837
Merge branch '4.0-dev' of https://github.com/joomla/joomla-cms into 2…
fatmaakay Aug 1, 2018
f8c971f
fixed code style
fatmaakay Aug 1, 2018
8988c5d
Merge branch '4.0-dev' into 21225-fix-menu-selection
roland-d Aug 2, 2018
38733ac
Merge branch '4.0-dev' into 21225-fix-menu-selection
infograf768 Aug 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions build/media/com_menus/js/admin-item-edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,21 @@
var data = JSON.parse(response);
var list = document.querySelectorAll('#jform_parent_id option');
list.forEach(function (item) {
if (item != '1') {
if (item.value !== '1') {
item.remove();
}
});

data.forEach(function (val) {
var option = document.createElement('option');
option.innerText = value;
option.innerText = val.title;
option.id = val.id;
document.getElementById('jform_parent_id').appendChild(option);
});
document.getElementById('jform_parent_id').trigger('change');

var event = document.createEvent('HTMLEvents');
event.initEvent('change', true, false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To normalize, would be good to indent with tabs for the 2 above lines instead of spaces

document.getElementById('jform_parent_id').dispatchEvent(event);
},
onError : function (xhr) {
Joomla.renderMessages(Joomla.ajaxErrorsMessages(xhr));
Expand Down