-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Remove vendor folders #21217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove vendor folders #21217
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7e9e3f3
remove files
rdeutz e27a349
ajust ignores
rdeutz 3f84ec2
build file changes
rdeutz b8fb764
reset package json file
rdeutz c4a0376
use the normal package.json
rdeutz db76d55
use the develop version of the docker image because we need a newer n…
rdeutz e214f02
symlink no longer needed
rdeutz 403027c
add joomla-javascript-tests to package.json
rdeutz 6b0d441
Merge branch '4.0-dev' into remove_vendor_folders
rdeutz 5a238db
update lock
rdeutz 2d1ef39
update webcomponents package
rdeutz c6bbd01
run npm as root in container is ok
rdeutz 7d485d1
update postinstall command
rdeutz bf3cde6
nightly build
rdeutz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be done after the
git archivecommand is run (line 97 pre-diff). That command is what creates the temporary space inbuild/tmp/<timestamp>based on a clean git clone from whatever remote is given, so doing thecomposer installin the repo root before extracting the git archive is going to be pointless.We should also do
composer install --no-dev --optimize-autoloaderso we don't get dev dependencies in build packages.We might also want to strip the extra files as a post install action (maybe make a Composer plugin for this?) that are in our
.gitignoreto keep us from shipping things like testing framework files, code examples (which has already bitten us in the past with the IDNA_Convert library), and other non-production assets.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add --ignore-platform-reqs too, so it doesn't require php ldap extension on the building host for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the clean up action