Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Jul 10, 2018

The list of indexed items in the backend of com_finder does not have a column for the language. Since we have this everywhere else, I'm adding it here, too.

@Quy
Copy link
Contributor

Quy commented Jul 11, 2018

https://github.com/joomla/joomla-cms/pull/21038/files#diff-96ae0370a620b2bdb4168d9f9ebab161R67
<td colspan="7">

Update column to be 7 or 8 depending on Multilanguage::isEnabled()

@Hackwar
Copy link
Member Author

Hackwar commented Jul 11, 2018

Updated the colspan to 8. I think it would be a waste of CPU cycles to check here again if multilanguage or not. Since it doesn't matter if we have 7, 8, 9 or 42 here, as long as we want it to span the whole table, I wouldn't change this.

@infograf768
Copy link
Member

Issue when filtering at the same time content map and language
screen shot 2018-09-19 at 12 25 42

@infograf768
Copy link
Member

I guess changes are needed in ContentmapField.php

@Hackwar
Copy link
Member Author

Hackwar commented Sep 19, 2018

There is no content that is both french and german at the same time, so this is an issue that we can't really fix. We could hide the language taxonomy branch when #21327 is also merged if it is a real issue.

@infograf768
Copy link
Member

I think that we should not present at all in filters or elsewhere anything related to Content Languages when the languagefilter is disabled, as we now do everywhere in Joomla.

@Hackwar
Copy link
Member Author

Hackwar commented Sep 22, 2018

Taxonomy has no idea what a branch means and we could only introduce a special handling for a branch that is named "Language", which again could not be present at all or deactivated or something. I'm not a fan of that...

…4finder_backendlist

# Conflicts:
#	administrator/components/com_finder/View/Index/HtmlView.php
#	administrator/components/com_finder/tmpl/index/default.php
@chmst
Copy link
Contributor

chmst commented Jan 8, 2019

I have tested this item ✅ successfully on 77cbda1

I've tested this item with multilingual sample data and made a code inspection.From this point of view the PR works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21038.

@ghost ghost added the J4 Issue label Apr 5, 2019
@ghost ghost removed the J4 Issue label Apr 13, 2019
@Quy
Copy link
Contributor

Quy commented Apr 19, 2019

I have tested this item ✅ successfully on 52ece71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21038.

@Quy
Copy link
Contributor

Quy commented Apr 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21038.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 19, 2019
…4finder_backendlist

# Conflicts:
#	administrator/components/com_finder/View/Index/HtmlView.php
@Hackwar
Copy link
Member Author

Hackwar commented May 20, 2019

Can we finally merge this?

@roland-d roland-d merged commit 679290f into joomla:4.0-dev Jun 14, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 14, 2019
@roland-d
Copy link
Contributor

Thank you.

@roland-d roland-d added this to the Joomla 4.0 milestone Jun 14, 2019
@Hackwar Hackwar deleted the j4finder_backendlist branch June 14, 2019 20:51
@Hackwar
Copy link
Member Author

Hackwar commented Jun 14, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants