-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.0] Adding language column to com_finder index backend #21038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
https://github.com/joomla/joomla-cms/pull/21038/files#diff-96ae0370a620b2bdb4168d9f9ebab161R67 Update column to be |
|
Updated the colspan to 8. I think it would be a waste of CPU cycles to check here again if multilanguage or not. Since it doesn't matter if we have 7, 8, 9 or 42 here, as long as we want it to span the whole table, I wouldn't change this. |
|
I guess changes are needed in ContentmapField.php |
|
There is no content that is both french and german at the same time, so this is an issue that we can't really fix. We could hide the language taxonomy branch when #21327 is also merged if it is a real issue. |
|
I think that we should not present at all in filters or elsewhere anything related to Content Languages when the languagefilter is disabled, as we now do everywhere in Joomla. |
|
Taxonomy has no idea what a branch means and we could only introduce a special handling for a branch that is named "Language", which again could not be present at all or deactivated or something. I'm not a fan of that... |
…4finder_backendlist # Conflicts: # administrator/components/com_finder/View/Index/HtmlView.php # administrator/components/com_finder/tmpl/index/default.php
|
I have tested this item ✅ successfully on 77cbda1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21038. |
Co-Authored-By: Hackwar <[email protected]>
|
I have tested this item ✅ successfully on 52ece71 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21038. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21038. |
…4finder_backendlist # Conflicts: # administrator/components/com_finder/View/Index/HtmlView.php
…into j4finder_backendlist
|
Can we finally merge this? |
|
Thank you. |
|
Thank you! |

The list of indexed items in the backend of com_finder does not have a column for the language. Since we have this everywhere else, I'm adding it here, too.