Skip to content

Com_finder meta data #20772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2018
Merged

Com_finder meta data #20772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
528624a
Com_finder meta data
brianteeman Jun 15, 2018
32e23ba
remove copy paste error
brianteeman Jun 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion components/com_finder/views/search/view.html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,16 +271,24 @@ protected function prepareDocument($query)
$explained = $this->escape(html_entity_decode(strip_tags($this->explained), ENT_QUOTES, 'UTF-8'));
$this->document->setDescription($explained);
}
elseif ($this->params->get('menu-meta_description'))
{
$this->document->setDescription($this->params->get('menu-meta_description'));
}

// Configure the document meta-keywords.
if (!empty($query->highlight))
{
$this->document->setMetaData('keywords', implode(', ', $query->highlight));
Copy link
Member

@carlitorweb carlitorweb Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this one too setMetaData -to setMetadata

Copy link
Contributor Author

@brianteeman brianteeman Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - its correct here (and wrong in some other places)

joomla-cms/libraries/src/Document/Document.php

Line 433 in 421749c

public function setMetaData($name, $content, $attribute = 'name')

Copy link
Member

@carlitorweb carlitorweb Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True!, sorry for this

Copy link
Contributor Author

@brianteeman brianteeman Jun 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem

it is used wrongly 80% of the time

}
elseif ($this->params->get('menu-meta_keywords'))
{
$this->document->setMetadata('keywords', $this->params->get('menu-meta_keywords'));
}

if ($this->params->get('robots'))
{
$this->document->setMetaData('robots', $this->params->get('robots'));
$this->document->setMetadata('robots', $this->params->get('robots'));
}

// Add feed link to the document head.
Expand Down