Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented May 29, 2018

Pull Request for Issue #20481, #20356 and #20484.

#20619 needs to be merged first!!

Moves com_config to the service based extension setup.

See #20217 for details.

@brianteeman
Copy link
Contributor

because #20619 needs to be merged first according to the test instructions this cannot be tested with com_patchtester

@laoneo
Copy link
Member Author

laoneo commented May 30, 2018

Why do you can't test it with patch tester? Is there an error?

@infograf768
Copy link
Member

Why do you can't test it with patch tester? Is there an error?

afaik patchtester can't move files around.

@laoneo
Copy link
Member Author

laoneo commented May 30, 2018

Ok, here is a link to the branch where you can download joomla directly https://github.com/Digital-Peak/joomla-cms/archive/j4/services/config.zip

@brianteeman
Copy link
Contributor

it cant be tested with patchtester as you say it needs #20619 installed first and as this also touches one of the same files patchtester prevents this one being applied

@laoneo
Copy link
Member Author

laoneo commented May 30, 2018

#20619 is included in this pr as well, otherwise I couldn't develop it either

@brianteeman
Copy link
Contributor

ah - then your message was confusing

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 13bf706

Tested the admin and works
Tested the site config and template config from front end and previous issues are resolved by this pr


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20620.

@wilsonge wilsonge merged commit f269304 into joomla:4.0-dev Jun 4, 2018
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 4, 2018
@wilsonge wilsonge deleted the j4/services/config branch June 4, 2018 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants