Email Domain Restrictions #20383

SharkyKZ · 2018-05-13T15:26:28Z

Pull Request for Issue # .

Summary of Changes

This PR adds user email domain restrictions. This is an alternative to #20164 with more flexibility added.

Testing Instructions

Apply patch.
Go to Users configuration.
In Email Domain Options add some rules.

a) Try to register with disallowed email.
b) Try to register with an email that isn't disallowed.
c) Try to change email in user profile to a disallowed email.
d) Try to change email in user profile to an allowed email.
e) Remove all rules and try to register again.

Expected result

a) Registration fails.
b) Registration successful.
c) Changes not saved.
d) Changes saved.
e) Registration successful.

Documentation Changes Required

Document the new option.
Document validDomains attribute usage in EmailRule.
Document message property in FormRule.

Sync

Quy · 2018-05-13T15:43:33Z

On the backend, text not translated JGLOBAL_EMAIL_DOMAIN_NOT_ALLOWED.

SharkyKZ · 2018-05-13T15:49:41Z

Added strings. Thanks.

brianteeman

Surely we have a string for this already

Quy · 2018-05-13T16:18:03Z

For the Rule, how about making it a radio type with the red/green switcher instead of a list?

Quy · 2018-05-13T17:06:09Z

libraries/src/Form/Rule/EmailRule.php

+					{
+						if ($domain->rule == 0)
+						{
+							$allowed = false;


Put a break here since there is no point in processing additional rules if any.

No, this would prevent other rules from overwriting the first matched rule.

infograf768 · 2018-05-13T17:21:16Z

administrator/language/en-GB/en-GB.com_users.ini

 COM_USERS_CONFIG_FIELD_CAPTCHA_LABEL="Captcha"
 COM_USERS_CONFIG_FIELD_CHANGEUSERNAME_DESC="Allow users to change their Username when editing their profile."
 COM_USERS_CONFIG_FIELD_CHANGEUSERNAME_LABEL="Change Username"
+COM_USERS_CONFIG_FIELD_DOMAIN_NAME_DESC="Enter a domain name. Wildcards (*) are supported. For example:<br /><b>*</b> allows or disallows all domains;<br /><b>*.com</b> allows or disallows all .com domains;<br /><b>*.joomla.org</b> allows or disallows all joomla.org subdomains."


please use strong instead of b

infograf768 · 2018-05-13T17:22:13Z

administrator/language/en-GB/en-GB.ini

 JGLOBAL_EDIT_ITEM="Edit item"
 JGLOBAL_EDIT_PREFERENCES="Edit Preferences"
 JGLOBAL_EMAIL="Email"
+JGLOBAL_EMAIL_DOMAIN_NOT_ALLOWED="The email domain <b>%s</b> is not allowed. Please enter another email address."


same comment

infograf768 · 2018-05-13T17:22:45Z

language/en-GB/en-GB.ini

 JGLOBAL_EDIT="Edit"
 JGLOBAL_EDIT_TITLE="Edit article"
 JGLOBAL_EMAIL="Email"
+JGLOBAL_EMAIL_DOMAIN_NOT_ALLOWED="The email domain <b>%s</b> is not allowed. Please enter another email address."


same comment

SharkyKZ · 2018-05-13T17:54:50Z

@brianteeman previously this was used:

COM_USERS_PROFILE_EMAIL1_MESSAGE="The email address you entered is already in use or invalid. Please enter another email address."

Although we could update it to read "The email address you entered is already in use, not allowed or invalid. Please enter another email address.", a change in this PR allows to output a different message based on which part of validation fails. This is more user friendly, IMO.

SharkyKZ · 2018-07-02T16:54:14Z

All domains are allowed by default and rules are executed in order, starting at the top. To allow only specific domain, you must first block all other domains. So to allow only *.example.org need to swap your rules:

* : Disallowed
*.example.org : Allowed

infograf768 · 2018-07-03T05:22:51Z

re-started travis

SharkyKZ · 2018-07-03T05:28:29Z

Travis failure is correct. This needs new unit tests.

ReLater · 2018-07-03T10:12:21Z

@SharkyKZ

All domains are allowed by default and rules are executed in order, starting at the top. To allow only specific domain, you must first block all other domains. So to allow only *.example.org need to swap your rules:

That's why I've asked because I've tested both orderings and could not register with example.org.

I tested also without captcha => same result.

ReLater · 2018-07-03T10:25:07Z

Tested also unsuccessfully without dot, just *example.org

SharkyKZ · 2018-07-03T10:41:33Z

Yes, wildcards currently work on full segments only as per comments #20383 (comment). But this can be improved. Any suggestions welcome (especially for fixing tests).

ReLater · 2018-07-03T10:54:41Z

To clarify: I could not allow [email protected]. All tests unsuccessful. Makes no difference if my rule is with (#20383 (comment)) or without dot.

Joomla 3.8.11-dev nightly of yesterday.

infograf768 · 2018-07-03T15:16:25Z

@ReLater
I do not confirm your findings here. For me it works as intended. (Latest staging).

ReLater · 2018-07-04T11:17:36Z

@infograf768

I do not confirm your findings here. For me it works as intended. (Latest staging).

Thank you. Maybe I have to install a new staging. I'm using the Joomla upload/update feature for a longer time now with nightly update packages for 3.8.x. Or maybe a conflict with an installed 3rd extension. I will see.

ReLater · 2018-07-04T12:13:52Z

Forget this comment:

After a new installation of staging nightly build of today I have the same unsuccessful results like in comment #20383 (comment)
Could you please have a look on the settings there?

I've tried it also with other rules/domains than *.example.org.

* : Disallowed *.example.org : Allowed

PHP 7.1 and 7.2

PHP Built On | Linux dd1620 3.13.0-151-generic #201-Ubuntu SMP Wed May 30 14:22:13 UTC 2018 x86_64
Database Type | mysql
Database Version | 5.5.58-nmm1-log
Database Collation | utf8_general_ci
Database Connection Collation | utf8mb4_general_ci
PHP Version | 7.2.1
Web Server | Apache
WebServer to PHP Interface | fpm-fcgi
Joomla! Version | Joomla! 3.8.11-dev Development [ Amani ] 26-June-2018 15:45 GMT
Joomla! Platform Version | Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent | Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

ReLater · 2018-07-04T12:50:40Z

After 2 coffees => "Stupid me!"

For allowed email [email protected] one have to set

* : Disallowed 
example.org : Allowed

ReLater · 2018-07-04T12:51:28Z

I have tested this item ✅ successfully on c7a8282

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20383.}

ka3media · 2018-09-08T14:37:16Z

I have tested this item ✅ successfully on c7a8282

Tested on J3.9 alpha

Applied the patch and checked various rulesets and rule sorting to check if sorting has the expected behavior.

Works for me

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20383.}

ghost · 2018-09-08T14:38:40Z

Ready to Commit after 4 successful tests.

hamby · 2018-09-08T15:14:27Z

"Testing Instructions" from above a) - e) was tested successfully

But i found a other problem: Ording Dependence Problem

--> Registration of example.us is possible

--> Registration of example.us is NOT possible

ka3media · 2018-09-08T15:26:21Z

But that's the expected behavior... if the last action is "disallow all" than all is disallowed

mbabker · 2018-09-09T15:59:29Z

Fixed via 1ddb06d

810 · 2018-10-31T01:59:36Z

Any option to disable this feature?

Because I can't edit a user option now:

Quy · 2018-10-31T02:28:23Z

Try deleting the row.

810 · 2018-10-31T02:30:21Z

nothing happend when I click on -
IE11.1001.18267.0

810 · 2018-10-31T02:35:05Z

ie11

Edge:

Looks like html issue

Quy · 2018-10-31T02:45:05Z

Strange. I am able to delete so there are no entries.

810 · 2018-10-31T02:51:26Z

SharkyKZ added 14 commits April 27, 2018 18:30

Merge pull request #3 from joomla/staging

9c0aa77

Sync

Global language strings

8492107

Configuration language strings

63ef43d

Configuration options

13dc1a2

Domain subform

d114f13

Admin profile form

8fc0f5b

Admin user form

c92baa4

Site profile form

2992d11

Site registration form

afd2f1d

Use message from rule

4e9dd59

[FormRule] Add message property

7681929

[Form] Use FormRule message property

072c2d0

[EmailRule] Domain restrictions

a67b1ad

Update language strings

7a338fe

joomla-cms-bot added Language Change This is for Translators PR-staging labels May 13, 2018

Add global strings to admin

760eb28

Travis

c4057b4

brianteeman reviewed May 13, 2018

View reviewed changes

Quy reviewed May 13, 2018

View reviewed changes

infograf768 reviewed May 13, 2018

View reviewed changes

SharkyKZ added 3 commits May 13, 2018 17:51

Rename subform

5469927

Rename subform

0e4ed6b

Rename subform

3ce014a

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 8, 2018

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 8, 2018

This comment was marked as abuse.

Sign in to view

jeckodevelopment added the Feature label Sep 10, 2018

Quy mentioned this pull request Sep 12, 2018

[3.9] email domain options logic fail? #22148

Closed

tecpromotion mentioned this pull request Sep 15, 2018

[3.9] Email Domain Restrictions joomlagerman/joomla#565

Closed

810 mentioned this pull request Oct 31, 2018

Remove required field option on config_domain.xml #22880

Closed

Uh oh!

Email Domain Restrictions #20383

Email Domain Restrictions #20383

Uh oh!

Conversation

SharkyKZ commented May 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Expected result

Documentation Changes Required

Uh oh!

Quy commented May 13, 2018

Uh oh!

SharkyKZ commented May 13, 2018

Uh oh!

brianteeman left a comment

Choose a reason for hiding this comment

Uh oh!

Quy commented May 13, 2018

Uh oh!

Quy May 13, 2018

Choose a reason for hiding this comment

Uh oh!

SharkyKZ May 13, 2018

Choose a reason for hiding this comment

Uh oh!

infograf768 May 13, 2018

Choose a reason for hiding this comment

Uh oh!

infograf768 May 13, 2018

Choose a reason for hiding this comment

Uh oh!

infograf768 May 13, 2018

Choose a reason for hiding this comment

Uh oh!

SharkyKZ commented May 13, 2018

Uh oh!

SharkyKZ commented Jul 2, 2018

Uh oh!

infograf768 commented Jul 3, 2018

Uh oh!

SharkyKZ commented Jul 3, 2018

Uh oh!

ReLater commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ReLater commented Jul 3, 2018

Uh oh!

SharkyKZ commented Jul 3, 2018

Uh oh!

ReLater commented Jul 3, 2018

Uh oh!

infograf768 commented Jul 3, 2018

Uh oh!

ReLater commented Jul 4, 2018

Uh oh!

ReLater commented Jul 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Forget this comment:

Uh oh!

ReLater commented Jul 4, 2018

Uh oh!

ReLater commented Jul 4, 2018

Uh oh!

ka3media commented Sep 8, 2018

Uh oh!

ghost commented Sep 8, 2018

Uh oh!

hamby commented Sep 8, 2018

Uh oh!

ka3media commented Sep 8, 2018

Uh oh!

This comment was marked as abuse.

mbabker commented Sep 9, 2018

Uh oh!

810 commented Oct 31, 2018

Uh oh!

Quy commented Oct 31, 2018

Uh oh!

SharkyKZ commented May 13, 2018 •

edited

Loading

ReLater commented Jul 3, 2018 •

edited

Loading

ReLater commented Jul 4, 2018 •

edited

Loading