[4.0] Debug bar #20380
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| table.phpdebugbar-widgets-info { | ||
| margin-left: 5px; | ||
| margin-top: 5px; | ||
| } | ||
|
|
||
| table.phpdebugbar-widgets-info td { | ||
| border-bottom: 1px solid silver; | ||
| padding-right: 10px; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| (function ($) { | ||
|
|
||
| var csscls = PhpDebugBar.utils.makecsscls('phpdebugbar-widgets-'); | ||
| var InfoWidget = PhpDebugBar.Widgets.InfoWidget = PhpDebugBar.Widget.extend({ | ||
|
|
||
| tagName: 'table', | ||
|
|
||
| className: csscls('info'), | ||
|
|
||
| render: function () { | ||
| this.bindAttr('data', function (data) { | ||
| this.$el.empty(); | ||
| var tr; | ||
|
|
||
| var link = $('<a />') | ||
| .text('Info') | ||
| .attr('href', 'index.php?option=com_profiler&id=' + data.requestId) | ||
| .attr('target', '_blank'); | ||
|
|
||
| tr = $('<tr />') | ||
| .append($('<td />').text('Info')) | ||
| .append($('<td />').append(link)); | ||
| this.$el.append(tr); | ||
|
|
||
| tr = $('<tr />') | ||
| .append($('<td />').text('Joomla! Version')) | ||
| .append($('<td />').text(data.joomlaVersion)); | ||
| this.$el.append(tr); | ||
|
|
||
| tr = $('<tr />') | ||
| .append($('<td />').text('PHP Version')) | ||
| .append($('<td />').text(data.phpVersion)); | ||
| this.$el.append(tr); | ||
| }); | ||
| } | ||
| }); | ||
| })(PhpDebugBar.$); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| table.phpdebugbar-widgets-languageFiles { | ||
| margin-left: 5px; | ||
| margin-top: 5px; | ||
| } | ||
|
|
||
| table.phpdebugbar-widgets-languageFiles tr { | ||
| border-bottom: 1px solid silver; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| (function ($) { | ||
|
|
||
| var csscls = PhpDebugBar.utils.makecsscls('phpdebugbar-widgets-'); | ||
| var languageFilesWidget = PhpDebugBar.Widgets.languageFilesWidget = PhpDebugBar.Widget.extend({ | ||
|
|
||
| tagName: 'table', | ||
|
|
||
| className: csscls('languageFiles'), | ||
|
|
||
| render: function () { | ||
| this.bindAttr('data', function (data) { | ||
| this.$el.empty(); | ||
| var tr; | ||
| for (var extension in data) { | ||
| var ul = $('<ul />'); | ||
| for (var file in data[extension]) { | ||
| var css = data[extension][file] ? 'alert-success' : 'alert-warning'; | ||
| var li = $('<li />') | ||
| .addClass(css) | ||
| .text(file).appendTo(ul); | ||
| } | ||
| tr = $('<tr />') | ||
| .append($('<td />').text(extension)) | ||
| .append($('<td />').append(ul)); | ||
| this.$el.append(tr); | ||
| } | ||
| }); | ||
| } | ||
| }); | ||
| })(PhpDebugBar.$); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| <?php | ||
| /** | ||
| * @package Joomla.Plugin | ||
| * @subpackage System.Debug | ||
| * | ||
| * @copyright Copyright (C) 2017 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
|
|
||
| namespace Joomla\Plugin\System\Debug; | ||
|
|
||
| use DebugBar\DataCollector\DataCollector; | ||
| use DebugBar\DataCollector\Renderable; | ||
| use DebugBar\DataFormatter\DataFormatterInterface; | ||
| use Joomla\Registry\Registry; | ||
|
|
||
| /** | ||
| * AbstractDataCollector | ||
| * | ||
| * @since __DEPLOY_VERSION__ | ||
| */ | ||
| abstract class AbstractDataCollector extends DataCollector implements Renderable | ||
| { | ||
| /** | ||
| * @var Registry | ||
|
||
| * @since __DEPLOY_VERSION__ | ||
| */ | ||
| protected $params; | ||
|
|
||
| /** | ||
| * @var DataFormatter | ||
| * @since __DEPLOY_VERSION__ | ||
| */ | ||
| private static $defaultDataFormatter; | ||
|
|
||
| /** | ||
| * AbstractDataCollector constructor. | ||
| * | ||
| * @param Registry $params Parameters. | ||
| * | ||
| * @since __DEPLOY_VERSION__ | ||
| */ | ||
| public function __construct(Registry $params) | ||
| { | ||
| $this->params = $params; | ||
| } | ||
|
|
||
| /** | ||
| * Get a data formatter. | ||
| * | ||
| * @since __DEPLOY_VERSION__ | ||
| * @return DataFormatterInterface | ||
| */ | ||
| public function getDataFormatter(): DataFormatterInterface | ||
| { | ||
| if ($this->dataFormater === null) | ||
| { | ||
| $this->dataFormater = self::getDefaultDataFormatter(); | ||
| } | ||
|
|
||
| return $this->dataFormater; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the default data formater | ||
| * | ||
| * @since __DEPLOY_VERSION__ | ||
| * @return DataFormatterInterface | ||
| */ | ||
| public static function getDefaultDataFormatter(): DataFormatterInterface | ||
| { | ||
| if (self::$defaultDataFormatter === null) | ||
| { | ||
| self::$defaultDataFormatter = new DataFormatter; | ||
| } | ||
|
|
||
| return self::$defaultDataFormatter; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to use one of the other methods in this file. The reason is that we want to keep the convention
vendor/name/js. Mind the lastjsfolder. This enables joomla's HTMLHelper::script() to override the scripts if one is found in the relevant template folder (egtemplates/some-template/js/vendor/name/some-script.js).Just add a @todo above the line and I will do the rest once this is merged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's just about the
/jsfolder I guess I could just add that to thedestpath of the copy command and adjust my path?I am more concerned about the fact that somebody could run
npm ibefore runningcomposer installso the copy command here would obviously fail...It just feels that stuff is done in the
wrong_place™In the mean time I have added a
@todoand feel good having that working (again)Thanks for your help and keep up the good work 🕺