[4.0] Count on non-Countable object #20323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go to extensions->manage->database `Warning: count(): Parameter must be an array or an object that implements Countable in C:\htdocs\cms4\libraries\src\Schema\ChangeItem.php on line 214` Apply patch no more warning
wilsonge
reviewed
May 9, 2018
|
|
||
| try | ||
| { | ||
| $rows = $this->db->loadObject(); |
Contributor
There was a problem hiding this comment.
You can remove the $rows=== false check directly below as loadRowList can only return an array (currently it's documented as returning null but that's just a doc block bug I've fixed with joomla-framework/database#122 - either way it can't be false)
Contributor
Author
There was a problem hiding this comment.
This pr is the same as #18443 which was merged 5 months ago in 3.x but not merged in to 4.0 yet
Contributor
|
That has just been merged in from staging :) - thanks though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using php 7.2 and above
Go to extensions->manage->database
Warning: count(): Parameter must be an array or an object that implements Countable in C:\htdocs\cms4\libraries\src\Schema\ChangeItem.php on line 214Apply patch
no more warning