Removing MooTools dependencies from core.js #2010
Removing MooTools dependencies from core.js #2010betweenbrain merged 6 commits intojoomla:masterfrom AshanFernando:gsoc-mootools-jquery-core
Conversation
…, and including it and its dependencies in behavior.php TODO: Implement jQuery version in that file
…ile core-jquery-uncompressed.js Modified functions: Joomla.renderMessages, Joomla.removeMessages
…eplacing the core-uncompressed.js with jQuery version, Fixing "Joomla" object not found error
|
Thanks @AshanFernando! |
There was a problem hiding this comment.
There is a merge conflict with this line, and it appears that it needs to be if (typeof(task) !== 'undefined' && task !== "") { per 09ad7b6
There was a problem hiding this comment.
The modifications are sent with the new PR
#2687
|
Hello @AshanFernando, My apologies for any confusion that I may have caused with this pull request. It seems that I was too quick to merge it as we may need to deprecate I'd very much like to your work into Joomla as soon as possible, but I will need to speak to the others how best to approach this. In the meantime, it seems as though Github will not allow me to reopen this pull request. Would it be possible to see if you can reopen it by pushing more commits to this branch, or make a new pull request, with an update from the comment I left at https://github.com/joomla/joomla-cms/pull/2010/files#r8267444 ? |
|
Hi Matt, I will check on the issue and please update the findings you get after the discussion with others |
|
@AshanFernando I have an idea how it could be done after your PR is merged:
I think that should work then. What do you think? |
Under GSoC MooTools to jQuery project, this PR removes the MooTools dependencies in core.js file.
Feature Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31583&start=500