Skip to content

Comments

Removing MooTools dependencies from core.js #2010

Merged
betweenbrain merged 6 commits intojoomla:masterfrom
AshanFernando:gsoc-mootools-jquery-core
Dec 11, 2013
Merged

Removing MooTools dependencies from core.js #2010
betweenbrain merged 6 commits intojoomla:masterfrom
AshanFernando:gsoc-mootools-jquery-core

Conversation

@AshanFernando
Copy link
Contributor

Under GSoC MooTools to jQuery project, this PR removes the MooTools dependencies in core.js file.

Feature Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31583&start=500

…, and including it and its dependencies in behavior.php TODO: Implement jQuery version in that file
…ile core-jquery-uncompressed.js

Modified functions: Joomla.renderMessages, Joomla.removeMessages
…eplacing the core-uncompressed.js with jQuery version, Fixing "Joomla" object not found error
@betweenbrain betweenbrain merged commit a47c1fe into joomla:master Dec 11, 2013
@betweenbrain
Copy link
Contributor

Thanks @AshanFernando!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict with this line, and it appears that it needs to be if (typeof(task) !== 'undefined' && task !== "") { per 09ad7b6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modifications are sent with the new PR
#2687

@betweenbrain
Copy link
Contributor

Hello @AshanFernando,

My apologies for any confusion that I may have caused with this pull request. It seems that I was too quick to merge it as we may need to deprecate JHtmlBehavior::framework for 4.0. Please see 6b86515 for the corresponding discussion.

I'd very much like to your work into Joomla as soon as possible, but I will need to speak to the others how best to approach this.

In the meantime, it seems as though Github will not allow me to reopen this pull request. Would it be possible to see if you can reopen it by pushing more commits to this branch, or make a new pull request, with an update from the comment I left at https://github.com/joomla/joomla-cms/pull/2010/files#r8267444 ?

@AshanFernando
Copy link
Contributor Author

Hi Matt, I will check on the issue and please update the findings you get after the discussion with others

@Bakual
Copy link
Contributor

Bakual commented Dec 12, 2013

@AshanFernando I have an idea how it could be done after your PR is merged:

  • Add a new function JHtmlBehavior::core which loads jQuery and core.js.
  • Replace the call for jQuery and core.js in JHtmlBehavior::framework with this new function. This will move this parts out and we will be able to easily deprecate the function in a later stage.
  • In JHtmlBehavior::multiselect and similar functions we change JHtml::_('script', 'system/multiselect.js', true, true); to JHtml::_('script', 'system/multiselect.js', false, true); and add a call to JHtmlBehavior::core instead.

I think that should work then. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants