Skip to content

[com_finder] - fix update inner join syntax for postgres #19964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2018
Merged

[com_finder] - fix update inner join syntax for postgres #19964

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ab8e6ef
[com_finder] - fix update inner join syntax for postgres
alikon Mar 22, 2018
193d52e
drone fix
alikon Mar 22, 2018
f28f36c
quoteName vs qn
alikon Mar 23, 2018
eabc728
cs
alikon Apr 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions administrator/components/com_finder/helpers/indexer/indexer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,10 @@ public function remove($linkId)
{
// Update the link counts for the terms.
$query->clear()
->update($db->quoteName('#__finder_terms', 't'))
Copy link
Contributor

@mbabker mbabker Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert the changes to use the shortcuts? When reading the code the full method names are clearer than the shortcuts, especially to newer contributors (IIRC at one point we tried standardizing the repo to use the full names over the shortcuts, or maybe I'm mis-remembering).

Copy link
Contributor Author

@alikon alikon Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readability vs laziness, readability should win ;)
done

->join('INNER', $db->quoteName('#__finder_links_terms' . dechex($i), 'm') . ' ON m.term_id = t.term_id')
->set('t.links = t.links - 1')
->where($db->quoteName('m.link_id') . ' = ' . (int) $linkId);
->update($db->qn('#__finder_terms', 't'))
->join('INNER', $db->qn('#__finder_links_terms' . dechex($i), 'm') . ' ON ' . $db->qn('m.term_id') . ' = ' . $db->qn('t.term_id'))
->set($db->qn('links') . ' = ' . $db->qn('links') . ' - 1')
->where($db->qn('m.link_id') . ' = ' . (int) $linkId);
$db->setQuery($query)->execute();

// Remove all records from the mapping tables.
Expand Down