Skip to content

[Regression] Menu item type url with rel attribute nofollow #19949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2018
Merged

[Regression] Menu item type url with rel attribute nofollow #19949

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0c9d1a
Menu item url attribute rel nofollow with target blank
Devportobello Mar 20, 2018
01e5cc3
logic
Devportobello Mar 20, 2018
dbd67f0
cs
Devportobello Mar 20, 2018
95e21c9
cs fix - thx Quy
Devportobello Mar 20, 2018
8156ddd
concat
Devportobello Mar 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/mod_menu/tmpl/default_url.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@
{
$attributes['target'] = '_blank';
$attributes['rel'] = 'noopener noreferrer';
if ($item->anchor_rel == 'nofollow')
Copy link
Contributor

@Quy Quy Mar 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line before line 53.

{
$attributes['rel'] = 'nofollow noopener noreferrer';
Copy link
Contributor

@Quy Quy Mar 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing it to? $attributes['rel'] .= ' nofollow';

Copy link
Contributor Author

@Devportobello Devportobello Mar 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, dunno if this should be better

}
}
elseif ($item->browserNav == 2)
{
Expand Down