[4.0] Ensure the CMSApplications do always have an identity#19766
Merged
wilsonge merged 8 commits intojoomla:4.0-devfrom Feb 25, 2018
Merged
[4.0] Ensure the CMSApplications do always have an identity#19766wilsonge merged 8 commits intojoomla:4.0-devfrom
wilsonge merged 8 commits intojoomla:4.0-devfrom
Conversation
mbabker
reviewed
Feb 23, 2018
| // Ensure the identity is loaded | ||
| if (!$this->getIdentity()) | ||
| { | ||
| $this->loadIdentity(Factory::getUser()); |
Contributor
There was a problem hiding this comment.
This should be in the after session start event handler. This will arbitrarily trigger $session->start() if it hasn't been called before this.
Contributor
There was a problem hiding this comment.
The afterSessionStart method until we get that properly abstracted out of the application class chain.
mbabker
reviewed
Feb 23, 2018
| // Ensure the identity is loaded | ||
| if (!$this->getIdentity()) | ||
| { | ||
| $this->loadIdentity(Factory::getUser()); |
Contributor
There was a problem hiding this comment.
Now you can just do $session->get('user'); and all is well (otherwise you're just going through a chain of 3 or 4 method calls to get the same session object you have 10 lines above).
Contributor
|
I have tested this item ✅ successfully on eae680d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19766. |
mbabker
approved these changes
Feb 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The CMSApplications needs always an identity.
Testing Instructions
Expected result
Actual result
The following error is thrown:
Call to a member function authorise() on null