Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Feb 13, 2018

Unit tests are broken because of #19528.

@wilsonge
Copy link
Contributor

wilsonge commented Feb 13, 2018

I'd missed you doing this until i was about to submit my version - but as it's a bit of a different solution to yours going to leave both open so you and @mbabker can compare and see which you like more. See #19672

@laoneo
Copy link
Member Author

laoneo commented Feb 16, 2018

Closing in favor of #19703.

@laoneo laoneo closed this Feb 16, 2018
@laoneo laoneo deleted the j4/fix/tests branch February 16, 2018 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants