Skip to content

Comments

Revert content archive routing#19561

Merged
mbabker merged 2 commits intojoomla:stagingfrom
csthomas:revert_archive
Feb 5, 2018
Merged

Revert content archive routing#19561
mbabker merged 2 commits intojoomla:stagingfrom
csthomas:revert_archive

Conversation

@csthomas
Copy link
Contributor

@csthomas csthomas commented Feb 4, 2018

Summary of Changes

This is the simple reversion of two commits, my (#19447) and @alikon (#19397).
If someone has more time then may try to fix it in a better way.

After merging #19512, the above PRs stop working and should also be reversed.

Because of inheritance active menu item, the archive view has a conflict with article view.
Reverting the only one commit does not help.

Links like /archive/123-category/12-article with segments after /archive - does not work in staging but it works in 3.8.3

Testing Instructions

  1. Install joomla staging (3.8.5-rc) with testing sample data.
  2. Unpublish all menu items form com_content except one archive view and set home as featured view.
  3. Archive a few articles
  4. Go to /archive link
  5. Now you should see a list of archived articles and its links like:
    • /archive/75-sample-data-articles/joomla/extensions/modules/navigation-modules/61-breadcrumbs-module
  6. Click to one of them
  7. In 3.8.3 you will go to an article, in staging you stay in archive view, after PR you go to article as in 3.8.3.

Expected result

Go to article.

Actual result

Stay in archive view.

Documentation Changes Required

No

@esedic
Copy link
Contributor

esedic commented Feb 4, 2018

I have tested this item ✅ successfully on 4ddbefe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19561.

@waader
Copy link
Contributor

waader commented Feb 5, 2018

I have tested this item ✅ successfully on 4ddbefe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19561.

@ghost
Copy link

ghost commented Feb 5, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 5, 2018
@infograf768 infograf768 added this to the Joomla 3.8.5 milestone Feb 5, 2018
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Feb 5, 2018
@csthomas csthomas deleted the revert_archive branch February 5, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants