Revert content archive routing#19561
Merged
mbabker merged 2 commits intojoomla:stagingfrom Feb 5, 2018
Merged
Conversation
added 2 commits
February 4, 2018 13:37
This reverts commit 01a9147.
Contributor
|
I have tested this item ✅ successfully on 4ddbefe This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19561. |
Contributor
|
I have tested this item ✅ successfully on 4ddbefe This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19561. |
|
Ready to Commit after two successful tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This is the simple reversion of two commits, my (#19447) and @alikon (#19397).
If someone has more time then may try to fix it in a better way.
After merging #19512, the above PRs stop working and should also be reversed.
Because of inheritance active menu item, the archive view has a conflict with article view.
Reverting the only one commit does not help.
Links like
/archive/123-category/12-articlewith segments after/archive- does not work in staging but it works in 3.8.3Testing Instructions
archiveview and set home as featured view./archivelink/archive/75-sample-data-articles/joomla/extensions/modules/navigation-modules/61-breadcrumbs-moduleExpected result
Go to article.
Actual result
Stay in archive view.
Documentation Changes Required
No