Skip to content

[4.0] Deprecate Table::getInstance #19529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2018
Merged

[4.0] Deprecate Table::getInstance #19529

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
399d300
Deprecate Table::getInstance
laoneo Feb 2, 2018
b325b30
Also deprecate addIncludePath
laoneo Feb 2, 2018
bc3859b
Typo
laoneo Feb 3, 2018
33f49b5
Merge branch '4.0-dev' into j4/deprecate/table
laoneo Feb 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libraries/src/Table/Table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,8 @@ public function getFields($reload = false)
*
* @return Table|boolean A Table object if found or boolean false on failure.
*
* @since 11.1
* @since 11.1
* @deprecated 5.0 Use the MvcFactory instead
*/
public static function getInstance($type, $prefix = 'JTable', $config = array())
{
Expand Down Expand Up @@ -318,7 +319,8 @@ public static function getInstance($type, $prefix = 'JTable', $config = array())
*
* @return array An array of filesystem paths to find Table classes in.
*
* @since 11.1
* @since 11.1
* @deprecated 5.0 Should not be used anymore as tables are loaded trough the MvcFactory
Copy link
Contributor

@wilsonge wilsonge Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: through

*/
public static function addIncludePath($path = null)
{
Expand Down