Skip to content

Conversation

@okonomiyaki3000
Copy link
Contributor

@okonomiyaki3000 okonomiyaki3000 commented Nov 27, 2017

Pull Request for Issue # .

Summary of Changes

http://codemirror.net/doc/releases.html

Testing Instructions

Use CodeMirror

Expected result

It should work as usual.

Actual result

It works.

Documentation Changes Required

No

@okonomiyaki3000
Copy link
Contributor Author

The check is wrong. This does not fail.

@brianteeman
Copy link
Contributor

could you update this to 5.33 please and then i can test it

@okonomiyaki3000
Copy link
Contributor Author

And don't forget these other fine CodeMirror PRs:

#12542
#17042
#18881

@joomla-cms-bot joomla-cms-bot changed the title Codemirror updated to 5.32.0 Codemirror updated to 5.33.0 Dec 23, 2017
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.4 milestone Dec 23, 2017
@Quy
Copy link
Contributor

Quy commented Dec 23, 2017

I have tested this item ✅ successfully on 79008a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18880.

@okonomiyaki3000
Copy link
Contributor Author

Really, still? These usually merge right away...

@okonomiyaki3000
Copy link
Contributor Author

Thanks!

@okonomiyaki3000 okonomiyaki3000 deleted the CodeMirror-Update branch January 18, 2018 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants