Skip to content

Conversation

@Achal-Aggarwal
Copy link
Contributor

... in form fields and unit tests.

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31347

Instructions
Just merge that code branch and use HTML5 attribute.
For attribute

  1. placeholder : use hint=”Placeholder text” to set placeholder
  2. required : use required=”true” or required=”required” or required=”1” to make field required
  3. autocomplete : use autocomplete=”false” or autocomplete=”off” or autocomplete=”0” to disable autocomplete.
  4. autofocus : use autofocus=”true” or autofocus=”on” or autofocus=”1” to set focus automatically to the field.
  5. spellcheck : use spellcheck =”false” or spellcheck =”off” or spellcheck =”0” to disable spellcheck.
  6. multiple : use multiple=”true” or multiple=”required” so that field can accept multiple values of its type.
    There is little bit refactoring with respect to boolean attributes (disabled, readonly), so everything should work as it does previously.

For the non-supported browsers, fallback js is automatically loaded to support it
Usage of some common attributes are on http://docs.joomla.org/Text_form_field_type/3.2

Install this component and test new field attributes.
https://docs.google.com/file/d/0B3rA3UKTXpVsV2ttNUE5MGNqWkU/edit?usp=sharing

@Achal-Aggarwal
Copy link
Contributor Author

Only new attributes PR #1763

@nicksavov
Copy link
Contributor

Hi Achal,

It's out of sync. Please update it with the latest master. Thanks!

@Achal-Aggarwal
Copy link
Contributor Author

Hi Nick,

Now PR is in sync with current master

@mbabker
Copy link
Contributor

mbabker commented Oct 8, 2013

Could you sync this up please?

@Achal-Aggarwal
Copy link
Contributor Author

in a min.

@Achal-Aggarwal
Copy link
Contributor Author

@mbabker done. i have rebased this branch on current master

@elador
Copy link

elador commented Oct 20, 2013

There's a bug here: http://googlesummerofcode2.cloudaccess.net/index.php/demo
When you click on the text of Checkboxes Field "Chorizo", not the Chorizo-checkbox gets selected, but the Checkbox further up. The other checkboxes work correctly.
Note that I click on the text to get the tick, not in the actual box.
I'm on Chrome 29.0.1547.66

@Achal-Aggarwal
Copy link
Contributor Author

@elador Actually I have git installed on the server where that site is hosted and the site was not on master. I updated it to master but the problem is still there, Checkout http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30036 this is a known bug with some discussion and no solution still, if you can propose a solution please create a PR of it and post it on the tracker. Even suggestions are also welcome.

@piotr-cz
Copy link
Contributor

Would you be interested in submitting similar the patches for Joomla Framework \ Form package?

@Achal-Aggarwal
Copy link
Contributor Author

@piotr-cz I would love to but because of university work can't promise any time frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants