Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Jun 13, 2017

Pull Request for Issue #16574.

Summary of Changes

When a "Contact - Mail" custom field is assigned to a category, then on the front only the fields in the contact form should be shown where the actual contact belongs to.

Testing Instructions

  • Create a contact category A
  • Create a contact category B
  • Create a contact A for category A
  • Create a contact B for category B
  • Create a Mail custom field with the title A and assign it to category A
  • Create a Mail custom field with the title B and assign it to category B
  • Create a menu item for contact A
  • Create a menu item for contact B

Expected result

  • When opening contact A on the front only the custom field A should be shown below the contact form.
  • When opening contact B on the front only the custom field B should be shown below the contact form.

Actual result

  • When opening contact A on the front the custom field A and B are shown below the contact form.
  • When opening contact B on the front the custom field A and B are shown below the contact form.

@ghost
Copy link

ghost commented Jun 13, 2017

I have tested this item ✅ successfully on fc597d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16666.

@ghost
Copy link

ghost commented Jun 13, 2017

@federone @jnk22 please test.

@sandstorm871
Copy link

Looking to test this & hopefully not a daft question ;)
Tested in 3.7.3b1 & 3.8dev

How do you add "Create a Mail custom field with the title A "
I see custom fields as expected for text, textarea, calenadra, etc but none more mail?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16666.

@ghost
Copy link

ghost commented Jun 14, 2017

@sandstorm871:
bildschirmfoto 2017-06-14 um 18 20 38

@sandstorm871
Copy link

I have tested this item ✅ successfully on fc597d5

Set up as per test instructions & saw the issue as per described.
After applying patch #16666 saw the expected result.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16666.

@sandstorm871
Copy link

Ooh didn't know about that @franz-wohlkoenig Thanks.
Now successfully tested with patch #16666


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16666.

@ghost
Copy link

ghost commented Jun 14, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 14, 2017
@rdeutz rdeutz merged commit 16f072d into joomla:staging Jun 15, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Jun 15, 2017
@rdeutz rdeutz added this to the Joomla 3.7.3 milestone Jun 15, 2017
@laoneo laoneo deleted the cf/contact-mail-catid branch June 15, 2017 06:54
@federone
Copy link

federone commented Jun 18, 2017

@franz-wohlkoenig thank you very much, have tested and works well.

Best Wishes,
Federico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants