[4.0] Convert the cli scripts #16516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
reviewed
Jun 4, 2017
| protected function doExecute() | ||
| { | ||
| // Load an app which can be used later | ||
| JFactory::getApplication('site'); |
|
It crashes otherwise. It needs a global application available, another cli script is doing that as well. It's the problem we have to always have a global CMSApplication available trough JFactory. Another approach would be to set the cli app as global app. But then it crashes on functiona like getTemplate. Correctly this function would return the CMS interface. |
|
I mean part of the idea with the interface is to fix this stuff and have the cms application interface globally. I mean let's get this merged. But this needs fixing somehow... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a
CMSApplicationInterfacewas introduced in #16499 the rest of the cli scripts do need a brush up.