Skip to content

Fix indexer breaking words when they are partly enclosed via inline HTML tags #16165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 22, 2019
Merged

Fix indexer breaking words when they are partly enclosed via inline HTML tags #16165

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
419ca91
Fix indexer breaking words when they are partly styled by HTML inline…
ggppdk May 21, 2017
edc95a0
Code Styling fix
ggppdk May 21, 2017
c27775e
CS fix
ggppdk May 21, 2017
56698b6
Merge branch 'staging' into patch-31
rdeutz May 27, 2017
5fbddb2
Valid HTML for the example in the comments
ggppdk May 9, 2018
ed675d2
Better example in comments
ggppdk May 9, 2018
950b9ec
Corrected case in the example
ggppdk May 10, 2018
2254a9b
Corrected spaces in the example
ggppdk May 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions administrator/components/com_finder/helpers/indexer/parser/html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,14 @@ public function parse($input)
// Convert entities equivalent to spaces to actual spaces.
$input = str_replace(array(' ', ' '), ' ', $input);

// This fixes issues such as '<h1>Title</h1><p>Paragraph</p>'
// being transformed into 'TitleParagraph' with no space.
$input = str_replace('>', '> ', $input);
// Add a space before both the OPEN and CLOSE tags of BLOCK and LINE BREAKING elements,
// e.g. 'all<h1><strong>m<strong/>obile</h1>List' will become 'all mobile list'
Copy link
Contributor

@wilsonge wilsonge May 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you have a header element here this is expected behaviour. Surely a header indicates something semantically different (i.e. not just a space)

Copy link
Contributor Author

@ggppdk ggppdk May 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just an example,
you can suggest a better / different example to use in this comment

Copy link
Contributor

@brianteeman brianteeman May 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that example doesnt work as it is invalid html

Copy link
Contributor Author

@ggppdk ggppdk May 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want me to change the example in the comments ? or mention that it will work even with invalid HTML ?

Copy link
Contributor

@brianteeman brianteeman May 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that H1 is always a block element and even tinymce will correct it so a better example would be

  •   // e.g. 'all<h1><em>m</em>obile  List</h1>'

$input = preg_replace('/(<|<\/)(' .
'address|article|aside|blockquote|br|canvas|dd|div|dl|dt|' .
'fieldset|figcaption|figure|footer|form|h1|h2|h3|h4|h5|h6|header|hgroup|hr|li|' .
'main|nav|noscript|ol|output|p|pre|section|table|tfoot|ul|video' .
')\b/i', ' $1$2', $input
);

// Strip HTML tags.
$input = strip_tags($input);
Expand Down