Skip to content

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR converts com_tags component to namespace MVC for Joomla 4.

Testing Instructions

As the none namespace version has issues, the test is just makes sure it works as before:

  1. Backend: Test and make sure add/edit/publish/unpublish.. works as expected.
  2. Frontend: Currently, view detail tag of some tags in sample data broken (routing issue, I guess). So just view list of tags, view some tags work

Known issues

  1. Routing to tag detail broken (for example Green tag in sample data)

  2. Viewing rss feed has some notices:

  • Notice: Undefined index: mime in E:\www\contact\libraries\joomla\document\feed.php on line 217
  • Notice: Undefined variable: tz in E:\www\contact\libraries\joomla\document\renderer\feed\rss.php on 247
  • Warning: DateTime::setTimezone() expects parameter 1 to be DateTimeZone, null given in E:\www\contact\libraries\joomla\date\date.php on line 408

@wilsonge wilsonge merged commit 49d3d33 into joomla:4.0-dev May 21, 2017
@wilsonge wilsonge added this to the Joomla 4.0 milestone May 21, 2017
@wilsonge
Copy link
Contributor

Routing fixed with 3f4914b and #13600

@wilsonge
Copy link
Contributor

RSS feed fixed with 813f69f

@joomdonation
Copy link
Contributor Author

Great. I am good with testing, then :D

@joomdonation joomdonation deleted the namespace_com_tags branch May 29, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants