fix mime checkes by zero-24 · Pull Request #16091 · joomla/joomla-cms

zero-24 · 2017-05-17T19:14:36Z

Pull Request for Issue #16086

Summary of Changes

If you have installed 3.7.1 and try to upload using com_media a file which is not a image you got an error that you can't upload it.

I have now:

Improved the checks
show the failing mime to the use
make sure that images are checked with the image functions and other files with the other checks
implemented a fallback for images
fixed a longstanding issuse with finfo_open (FILEINFO_MIME vs. FILEINFO_MIME_TYPE)

Testing Instructions

install 3.7.1
try to upload a PDF file.
it fails
try to upload a jpg file
it works
apply this patch
try the PDF and the image again
it works now

Now go to the options and don't allow uploading jpg images and PDF files (by removing the jpg & PDF mime from the allowed mime types

try to upload a jpg again
it should not work but now show the failing mime type. (image/jpg)
do the same for a PDF
it should also show the failing mime.

Expected result

If allowed the upload should work if not it should show the mime we detected to the user.

Actual result

non image files can't be uploaded using the media manger

Documentation Changes Required

none.

Quy · 2017-05-17T19:27:59Z

libraries/cms/helper/media.php

+
+							return false;
+						}
+					}


Change a to an and remove '

Quy · 2017-05-17T19:28:51Z

libraries/cms/helper/media.php

+
+						return false;
+					}
+				}


Change a to an and remove '.

Quy · 2017-05-17T19:29:28Z

libraries/cms/helper/media.php

+			// If we have any kind of error here => false;
+			return false;
+		}
+


Change cant to can't.

Quy · 2017-05-17T19:30:42Z

libraries/cms/helper/media.php

 				// If tmp_name is empty, then the file was bigger than the PHP limit
 				if (!empty($file['tmp_name']))
 				{
-					$result = $this->checkMimeType($file['tmp_name'], $component, true);


Change a to an. Add ; after type.

zero-24 · 2017-05-17T19:39:09Z

Should be fixed now thanks @Quy !

Quy · 2017-05-17T21:42:51Z

Uploaded a PDF file and got the error Invalid mime type detected. and in the PHP error log:

PHP Notice:  Undefined variable: mime in C:\xampp\htdocs\joomla371\libraries\cms\helper\media.php on line 92
PHP Notice:  Undefined variable: mime in C:\xampp\htdocs\joomla371\libraries\cms\helper\media.php on line 98

wilsonge · 2017-05-17T22:44:34Z

libraries/cms/helper/media.php

+				// We have fileinfo
+				$finfo = finfo_open(FILEINFO_MIME_TYPE);
+				$mime  = finfo_file($finfo, $file);
+				finfo_close($finfo);


Looks like from the test we have cases where none of these things exist!? Probably having a final else statement here with return false to reject everything if we can't detect things is going to be important

Fixed with: 298959e

N6REJ · 2017-05-18T01:57:28Z

following

Quy · 2017-05-18T05:08:52Z

libraries/cms/helper/media.php

+			}
+			elseif ($isImage && function_exists('getimagesize'))
+			{
+				$imagesize = getimagesize($file);


c/s remove outside () since not required.

Quy · 2017-05-18T05:14:39Z

libraries/cms/helper/media.php

-
-					finfo_close($finfo);
+					$imagesize = getimagesize($file);
+					$mime      = (isset($imagesize['mime'])) ? $imagesize['mime'] : false;


c/s remove outside () since not required.

infograf768 · 2017-05-18T06:39:37Z

Except for the cs #16091 (comment) this works for me

ghost · 2017-05-18T06:47:31Z

I have tested this item ✅ successfully on efc334f

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16091.}

ghost · 2017-05-18T06:47:57Z

set RTC, @infograf768?

infograf768 · 2017-05-18T07:12:34Z

Waiting for
$mime = (isset($imagesize['mime'])) ? $imagesize['mime'] : false;
to be corrected to
$mime = isset($imagesize['mime']) ? $imagesize['mime'] : false;

wilsonge · 2017-05-18T07:19:42Z

Quy's php notices need to be investigated before this can go RTC - clearly in some cases this isn't working fully

zero-24 · 2017-05-20T18:51:01Z

@EndeavorC ok i have finaly found something that could be the issue.

Please run the following SQL

select * from `#__extensions` where `element` = `com_media`;

And post the result here.

EndeavorC · 2017-05-20T19:23:57Z

Hello,

When I run the above SQL query in myPHPAdmin I get the following:

Error
SQL query: Documentation

select * from #__extensions where element = com_media LIMIT 0, 25

MySQL said: Documentation

#1146 - Table '.#__extensions' doesn't exist

Sorry this is not much help

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16091.}

zero-24 · 2017-05-20T19:25:06Z

Yes you need to replace #__ with your database prefix

EndeavorC · 2017-05-20T19:34:43Z

Error
SQL query: Documentation

select * from <prefix>_extensions where element = com_media LIMIT 0, 25
MySQL said: Documentation

#1054 - Unknown column 'com_media' in 'where clause'

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16091.}

EndeavorC · 2017-05-20T19:40:22Z

If I view the com_media table I have the following, not sure if this is what you are looking for:

name: com_media

type: component

element: com_media

manifest_cache:

{"name":"com_media","type":"component","creationDate":"April 2006","author":"Joomla! Project","copyright":"(C) 2005 - 2017 Open Source Matters. All rights reserved.","authorEmail":"admin@joomla.org","authorUrl":"www.joomla.org","version":"3.0.0","description":"COM_MEDIA_XML_DESCRIPTION","group":"","filename":"media"}

params:

{"upload_extensions":"bmp,csv,doc,gif,ico,jpg,jpeg,odg,odp,ods,odt,pdf,png,ppt,swf,txt,xcf,xls,BMP,CSV,DOC,GIF,ICO,JPG,JPEG,ODG,ODP,ODS,ODT,PDF,PNG,PPT,SWF,TXT,XCF,XLS","upload_maxsize":"10","file_path":"images","image_path":"images","restrict_uploads":"1","check_mime":"1","image_extensions":"bmp,gif,jpg,png","ignore_extensions":"","upload_mime":"image/jpeg,image/gif,image/png,image/bmp,application/x-shockwave-flash,application/msword,application/excel,application/pdf,application/powerpoint,text/plain,application/x-zip","upload_mime_illegal":"text/html"}

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16091.}

zero-24 · 2017-05-20T19:53:48Z

This is what I was looking for thanks. Can you please go to the com_media options and save them again. And than try uploading a image from the frontend again?

If this still don't work please send me a backup + the file you try to upload to tobias.zulauf[at]community.joomla.org as i'm running out of ideas what the issue could be. And I can not reproduce the problems.

EndeavorC · 2017-05-20T20:24:32Z

Saving the options did not solve the issue, what type of backup are you asking for?

zero-24 · 2017-05-20T20:54:01Z

file and database you can clear the content table if needed. So I can debug the issue.

gwsdesk · 2017-05-22T15:57:25Z

If I understand all properly I can mention that I have tested this item ✅ successfully on 672e183

EndeavorC · 2017-05-22T16:16:14Z

What permissions are you testing with for the user account? I am using an account with publisher. If I replace the media.php file with the one from 3.7.0 it works but not the updated one here or the one that was installed with 3.7.1.

I have tried with included editor (TinyMCE) and Ark Editor

sedonasky · 2017-05-23T15:55:52Z

I updated to 3.7.2 but still cannot upload PDFs. I cleared the cache, etc. and tried to upload with Super Admin permissions. I still get this error (so clients are still very unhappy).

Error
Invalid mime type detected.

zero-24 · 2017-05-23T17:01:29Z

@sedonasky

Error
Invalid mime type detected.

this means that finfo_open and mime_content_type did not work or are not available. Can you please check that they are installed and enabled on your server?

gwsdesk · 2017-05-23T17:06:54Z

I cannot replicate this on our servers https://gws-host.com/systems-technology

Imho this is a server issue/settings and not related to Joomla

Quy · 2017-05-23T17:11:16Z

this means that finfo_open and mime_content_type did not work or are not available. Can you please check that they are installed and enabled on your server?

Maybe include in the error message that finfo_open and mime_content_type could not be found and to contact their hosting provider.

gwsdesk · 2017-05-23T17:14:54Z

@Quy which would mean that for every specific hosting config with disabled functions we would have to create exemptions/messages? Does that make sense?

jen4web · 2017-05-23T19:15:49Z

I am having the same problem. Site is hosted with Rochen, PHP 7.0.19. Site is upgraded to 3.7.2, and I am uploading a PDF (131K) as a super user. JPG and PNG files upload without issue, so it's just PDF that's a problem.

zero-24 · 2017-05-23T20:58:12Z

Yes please check that one or both php functions are enabled.

fperillo · 2017-05-23T21:00:04Z

I confirm this patch is not working on 3.7.1 and 3.7.2, due to mime_content_type

PHP Fatal error: Call to undefined function mime_content_type() in - on line 1

OpenSuse 12.3 has php5-fileinfo extension module that is not installed on the server... fileinfo was not a pre-requisite when installing or updating.

zero-24 · 2017-05-23T21:03:19Z

I hope The mime type fatal error is not shown to the user?

But yes if both methods are not there there is no upload allowed as we cant check the mime types which is required for Security reasons.

fperillo · 2017-05-23T21:14:12Z

I understand, and I really don't know Joomla developers guidelines and, believe me, I don't want to be rude, but after a hot phone call with one user...
according to
https://downloads.joomla.org/technical-requirements
there is no need to install fileinfo package and adding this requirements you added external dependencies that not everybody can fulfill.
I and others installed php as required, and now it is not enough...

PS: I found a similar problem with gzdecode... in this case package php5-zlib is installed but this function is not present..

brianteeman · 2017-05-23T21:29:22Z

@fperillo fileinfo - This extension is enabled by default as of PHP 5.3.0. (http://php.net/manual/en/fileinfo.installation.php)

Joomla cannot be expected to tell you every php extension that needs to be enabled especially if it is enabled by default.

EndeavorC · 2017-05-23T21:40:37Z

My hosting company verified that both are installed but I am still unable to upload image files with 3.7.1 or the updated files. If I use the 3.7.0 files I am able to upload image files. I have not tried PDF files as we use another option for document. This is becoming very frustrating, the past 2 updates have had serious bugs and/or changes that have greatly impacted the volunteers that use the site.

…

________________________________ From: Brian Teeman <notifications@github.com> Sent: Tuesday, May 23, 2017 5:29:29 PM To: joomla/joomla-cms Cc: EndeavorC; Mention Subject: Re: [joomla/joomla-cms] fix mime checkes (#16091) @fperillo<https://github.com/fperillo> fileinfo - This extension is enabled by default as of PHP 5.3.0. (http://php.net/manual/en/fileinfo.installation.php) Joomla cannot be expected to tell you every php extension that needs to be enabled especially if it is enabled by default. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#16091 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Abe3gQPnxRazydiNkaTC8Mep2XP0VRTFks5r80-5gaJpZM4NeUZi>.

brianteeman · 2017-05-23T21:47:09Z

We are all volunteers as well

I see from the system info report that you posted before that you are using the ark editor on your site. If I understand your reports correctly you are able to upload images through the administrator but your editors can not at the front end. Are the editors using the ARK editor or the default tinymce editor? If they are using ARK can you try with the TinyMCe editor. I am not passing any blame here i am just trying to gather all the facts so that we can try to help you

EndeavorC · 2017-05-24T00:12:05Z

I have tried TinyMCE and ArkEditor from the front end with the same result, for some reason it does not work on the front end. I am not laying any blame but trying to provide what little troubleshooting or helpful information I may be able to provide.

…

________________________________ From: Brian Teeman <notifications@github.com> Sent: Tuesday, May 23, 2017 5:47:16 PM To: joomla/joomla-cms Cc: EndeavorC; Mention Subject: Re: [joomla/joomla-cms] fix mime checkes (#16091) We are all volunteers as well I see from the system info report that you posted before that you are using the ark editor on your site. If I understand your reports correctly you are able to upload images through the administrator but your editors can not at the front end. Are the editors using the ARK editor or the default tinymce editor? If they are using ARK can you try with the TinyMCe editor. I am not passing any blame here i am just trying to gather all the facts so that we can try to help you — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#16091 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Abe3gWawQeYSkGp9nPJpl3LrcjYkmO1xks5r81PkgaJpZM4NeUZi>.

jen4web · 2017-05-24T10:45:11Z

I have been uploading files through the Media Manager. JPG and PNG work, while PDF does not.

I reported this to Rochen, who confirmed that finfo_open and mime_content_type were installed, available, and working correctly.

Their response was this: "Well there seems to be compatibility issue with mime_content_type on Joomla version and PHP v7.0, If I switch the PHP version to v5.6 it is working fine.

It appears the patch provided isn't working on 3.7.1 and 3.7.2, due to mime_content_type. Thanks!"

Previously I was running PHP 7.0.19.

brianteeman · 2017-05-24T10:47:09Z

Thanks for the info about php 7.0 - that will hopefully help track it down

But as this issue is closed it wont be seen by most people so can I please ask you to open a new issue with this information

gwsdesk · 2017-05-24T16:39:54Z

I am sorry but I cannot replicate this on our servers (PHP 7.1.14). Neither in default media manager nor in /TinyMCEJCE. I can upload pdf's either from frontend or admin without problems and if pdf's disabled (in media options) I do get the proper message (extension not supported)

However: The pdf's show in the file system with FTP (after upload in the media manager but they do not show after upload in the media manager itself in the administrator (they are uploaded as stated since they show in the file manager with ftp) That only happens when uploaded in this case with Tiny/JCE but they show when uploaded with/in the admin panel in the media manager

so by using the media manager upload they show but when upload with any editor they don't show despite being listed in the file system (FTP)

zero-24 · 2017-05-24T16:45:41Z

Thanks. The PDFs are not supported in the frontend image form. (different issue).

As stated above and here #16238 it looks like a server / hosting issue.

Here you can find a PR with a better message incase your hosting did disable both checkers:
#16246

I'm going to lock this issue now. If there are still issues please see #16238 or open a new issue. Thanks.

zero-24 added 6 commits May 17, 2017 20:01

fix the issues

7dc15a2

add fallback

018a76c

missing return

8acc085

better handling

707fa77

doc blocks

be489e6

we need to use sprintf

42a430c

joomla-cms-bot added Language Change This is for Translators PR-staging labels May 17, 2017

zero-24 mentioned this pull request May 17, 2017

PDFs (And other files) dont upload in Joomla 3.7.1 #16086

Closed

zero-24 added 2 commits May 17, 2017 21:18

fix issue

cc17b90

drone

3a34785

Quy reviewed May 17, 2017

View reviewed changes

libraries/cms/helper/media.php

return false;

}

}

Copy link

Contributor

Quy May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change a to an and remove '

Quy reviewed May 17, 2017

View reviewed changes

libraries/cms/helper/media.php

return false;

}

}

Copy link

Contributor

Quy May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change a to an and remove '.

Quy reviewed May 17, 2017

View reviewed changes

libraries/cms/helper/media.php

// If we have any kind of error here => false;

return false;

}

Copy link

Contributor

Quy May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change cant to can't.

Quy reviewed May 17, 2017

View reviewed changes

fix comments thanks @Quy

efc334f

This comment was marked as abuse.

Sign in to view

wilsonge reviewed May 17, 2017

View reviewed changes

Quy reviewed May 18, 2017

View reviewed changes

rdeutz added the Release Blocker label May 18, 2017

rdeutz added this to the Joomla 3.7.2 milestone May 18, 2017

rdeutz removed the Release Blocker label May 20, 2017

joomla locked and limited conversation to collaborators May 24, 2017

Uh oh!

Conversation

zero-24 commented May 17, 2017 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zero-24 commented May 17, 2017

Uh oh!

This comment was marked as abuse.

Quy commented May 17, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

N6REJ commented May 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

infograf768 commented May 18, 2017

Uh oh!

ghost commented May 18, 2017

Uh oh!

ghost commented May 18, 2017

Uh oh!

infograf768 commented May 18, 2017

Uh oh!

wilsonge commented May 18, 2017

Uh oh!

zero-24 commented May 20, 2017

Uh oh!

EndeavorC commented May 20, 2017

Uh oh!

zero-24 commented May 20, 2017

Uh oh!

EndeavorC commented May 20, 2017

Uh oh!

EndeavorC commented May 20, 2017

Uh oh!

zero-24 commented May 20, 2017

Uh oh!

EndeavorC commented May 20, 2017

Uh oh!

zero-24 commented May 20, 2017

Uh oh!

gwsdesk commented May 22, 2017

Uh oh!

EndeavorC commented May 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sedonasky commented May 23, 2017

Uh oh!

zero-24 commented May 23, 2017

Uh oh!

gwsdesk commented May 23, 2017

Uh oh!

Quy commented May 23, 2017

Uh oh!

gwsdesk commented May 23, 2017

Uh oh!

jen4web commented May 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

zero-24 commented May 17, 2017 •

edited by joomla-cms-bot

Loading

EndeavorC commented May 22, 2017 •

edited

Loading

jen4web commented May 23, 2017 •

edited

Loading

fperillo commented May 23, 2017 •

edited

Loading

jen4web commented May 24, 2017 •

edited

Loading

gwsdesk commented May 24, 2017 •

edited

Loading