[codestyle] admin non-components xml files #15922

brianteeman · 2017-05-09T19:13:14Z

Review all the xml files in the administrator/components folder and make sure they are formatted according to the coding standards

(I had a long train journey)

zero-24 · 2017-05-09T19:43:10Z

administrator/modules/mod_status/mod_status.xml

 	<config>
 		<fields name="params">
-			<fieldset name="basic">
+		<fieldset name="basic">


this whole fieldset block needs one more tab

wojsmol · 2017-05-09T23:24:06Z

administrator/modules/mod_custom/mod_custom.xml

-					class="btn-group btn-group-yesno"
 					description="MOD_CUSTOM_FIELD_PREPARE_CONTENT_DESC"
-					default="1">
+					type="radio"


type before lebal

wojsmol · 2017-05-09T23:31:13Z

administrator/modules/mod_feed/mod_feed.xml

-					<option
-						value="1">JYES</option>
-					<option
-						value="0">JNO</option>


options deleted

@wojsmol they are ok now

@brianteeman corected this in 8b2075d.

wojsmol · 2017-05-09T23:52:07Z

administrator/modules/mod_popular/mod_popular.xml

 					label="COM_MODULES_FIELD_MODULECLASS_SFX_LABEL"
-					description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC" />
+					description="COM_MODULES_FIELD_MODULECLASS_SFX_DESC"
+					 rows="3"


unnidet space

wojsmol · 2017-05-09T23:53:34Z

administrator/modules/mod_stats_admin/mod_stats_admin.xml

+					description="COM_MODULES_FIELD_CACHE_TIME_DESC"
+					default="900"
+				/>
 				<field


wojsmol · 2017-05-09T23:57:23Z

administrator/modules/mod_status/mod_status.xml

+				<option value="1">JSHOW</option>
+				<option value="0">JHIDE</option>
+			</field>
+			<field


all fields in this fieldset - add empy line

wojsmol · 2017-05-10T00:01:38Z

administrator/templates/isis/templateDetails.xml

+					label="TPL_ISIS_COLOR_SIDEBAR_LABEL"
+					description="TPL_ISIS_COLOR_SIDEBAR_DESC" 
+					class="" 
+					type="color" 


type before lebal

yes. name, type, label, description as the others

wojsmol · 2017-05-10T00:02:24Z

administrator/templates/isis/templateDetails.xml

+					name="loginBackgroundColor" 
+					label="TPL_ISIS_COLOR_LOGIN_BACKGROUND_LABEL"
+					description="TPL_ISIS_COLOR_LOGIN_BACKGROUND_DESC"
+					type="color" 


type before lebal

yes. name, type, label, description as the others

wojsmol · 2017-05-10T00:03:02Z

administrator/templates/isis/templateDetails.xml

+					name="loginLogoFile" 
+					label="TPL_ISIS_LOGIN_LOGO_LABEL"
+					description="TPL_ISIS_LOGIN_LOGO_DESC"
+					type="media" 


type before lebal

yes. name, type, label, description as the others

wojsmol · 2017-05-10T00:04:28Z

administrator/templates/isis/templateDetails.xml

+					description="TPL_ISIS_HEADER_DESC"
+					class="btn-group btn-group-yesno"
+					default="1"
+					filter="integer">


> in new line

agree, as the others

wojsmol · 2017-05-10T00:07:30Z

@brianteeman check options formating https://developer.joomla.org/coding-standards/xml.html

andrepereiradasilva

some minor changes and also agree with @wojsmol comments.
if corrected is fine

andrepereiradasilva · 2017-05-31T13:44:50Z

administrator/modules/mod_feed/mod_feed.xml

-					<option
-						value="1">JYES</option>
-					<option
-						value="0">JNO</option>


@wojsmol they are ok now

andrepereiradasilva · 2017-05-31T13:45:37Z

administrator/modules/mod_latest/mod_latest.xml

 					<option
 						value="c_dsc">MOD_LATEST_FIELD_VALUE_ORDERING_ADDED</option>
 					<option
 						value="m_dsc">MOD_LATEST_FIELD_VALUE_ORDERING_MODIFIED</option>


proposed improvement: option in a single line

andrepereiradasilva · 2017-05-31T13:45:49Z

administrator/modules/mod_latest/mod_latest.xml

+					default="0"
+					>
 					<option
 						value="0">MOD_LATEST_FIELD_VALUE_AUTHORS_ANYONE</option>


proposed improvement: option in a single line

andrepereiradasilva · 2017-05-31T13:46:03Z

administrator/modules/mod_latest/mod_latest.xml


 				<field
 					name="moduleclass_sfx"
 					type="textarea" rows="3"


rows goes down

andrepereiradasilva · 2017-05-31T13:46:20Z

administrator/modules/mod_logged/mod_logged.xml

 				<field
 					name="count"
 					type="text"
 					default="5"


default goes down

andrepereiradasilva · 2017-05-31T13:51:25Z

administrator/templates/isis/templateDetails.xml

+					label="TPL_ISIS_COLOR_SIDEBAR_LABEL"
+					description="TPL_ISIS_COLOR_SIDEBAR_DESC" 
+					class="" 
+					type="color" 


yes. name, type, label, description as the others

andrepereiradasilva · 2017-05-31T13:51:59Z

administrator/templates/isis/templateDetails.xml

+					name="loginBackgroundColor" 
+					label="TPL_ISIS_COLOR_LOGIN_BACKGROUND_LABEL"
+					description="TPL_ISIS_COLOR_LOGIN_BACKGROUND_DESC"
+					type="color" 


yes. name, type, label, description as the others

andrepereiradasilva · 2017-05-31T13:52:18Z

administrator/templates/isis/templateDetails.xml

+					name="loginLogoFile" 
+					label="TPL_ISIS_LOGIN_LOGO_LABEL"
+					description="TPL_ISIS_LOGIN_LOGO_DESC"
+					type="media" 


yes. name, type, label, description as the others

andrepereiradasilva · 2017-05-31T13:52:40Z

administrator/templates/isis/templateDetails.xml

+					description="TPL_ISIS_HEADER_DESC"
+					class="btn-group btn-group-yesno"
+					default="1"
+					filter="integer">


agree, as the others

andrepereiradasilva · 2017-05-31T13:53:29Z

administrator/templates/isis/templateDetails.xml

 					value="1">TPL_ISIS_STATUS_BOTTOM</option>
-				<option
+					<option
 					value="0">TPL_ISIS_STATUS_TOP</option>


proposed improvement: option in a single line

brianteeman · 2017-05-31T14:33:06Z

all issues and conflicts have been resolved.
please mark test results and then this can be merged

andrepereiradasilva · 2017-05-31T14:44:18Z

I have tested this item ✅ successfully on a3672c9

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15922.}

i need to fix my ide!!

wojsmol · 2017-05-31T15:40:58Z

I have tested this item ✅ successfully on dfddfd5

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15922.}

andrepereiradasilva · 2017-05-31T15:58:59Z

I have tested this item ✅ successfully on dfddfd5

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15922.}

ghost · 2017-05-31T16:21:28Z

RTC after two successful tests.

brianteeman · 2017-06-04T12:49:53Z

Thanks

Codestyle

69154c9

joomla-cms-bot added the PR-staging label May 9, 2017

zero-24 reviewed May 9, 2017

View reviewed changes

indent

3160ba9

wojsmol reviewed May 9, 2017

View reviewed changes

order

e496c29

wojsmol reviewed May 9, 2017

View reviewed changes

oops

8b2075d

wojsmol reviewed May 9, 2017

View reviewed changes

wojsmol reviewed May 10, 2017

View reviewed changes

andrepereiradasilva reviewed May 31, 2017

View reviewed changes

brianteeman added 4 commits May 31, 2017 15:10

changes requested by @andrepereiradasilva

e452c49

cs

1ff29d6

Merge branch 'staging' into xml_code_admin_rest

8977d09

changes requested by @wojsmol

a3672c9

Quy added 3 commits May 31, 2017 16:22

Update mod_logged.xml (#43)

ca05381

Update templateDetails.xml (#45)

8a90e1e

i need to fix my ide!!

Update mod_popular.xml (#44)

dfddfd5

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 31, 2017

Quy added 12 commits May 31, 2017 17:23

Update templateDetails.xml (#57)

8efc76e

Update mod_version.xml (#56)

ec9e060

Update mod_toolbar.xml (#55)

27c5689

Update mod_title.xml (#54)

796ce03

Update mod_submenu.xml (#53)

3c41873

Update mod_status.xml (#52)

27b384f

Update mod_stats_admin.xml (#51)

df52190

Update mod_quickicon.xml (#50)

3f2e02d

Update mod_menu.xml (#49)

b122513

Update mod_login.xml (#48)

43ddad4

Update mod_latest.xml (#47)

dd40901

Update mod_feed.xml (#46)

02f7018

brianteeman modified the milestone: Joomla 3.7.3 May 31, 2017

brianteeman mentioned this pull request Jun 1, 2017

[codestyle] plugins xml #15932

Merged

wilsonge merged commit 2683f1d into joomla:staging Jun 4, 2017

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 4, 2017

brianteeman deleted the xml_code_admin_rest branch June 4, 2017 12:49

Uh oh!

[codestyle] admin non-components xml files #15922

[codestyle] admin non-components xml files #15922

Uh oh!

Conversation

brianteeman commented May 9, 2017 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wojsmol May 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wojsmol May 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wojsmol May 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wojsmol commented May 10, 2017

Uh oh!

andrepereiradasilva left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brianteeman commented May 31, 2017

Uh oh!

andrepereiradasilva commented May 31, 2017

Uh oh!

wojsmol commented May 31, 2017

Uh oh!

andrepereiradasilva commented May 31, 2017

brianteeman commented May 9, 2017 •

edited by joomla-cms-bot

Loading

wojsmol May 9, 2017 •

edited

Loading

wojsmol May 9, 2017 •

edited

Loading

wojsmol May 10, 2017 •

edited

Loading