Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 3, 2013

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31323

These are code style and minor syntax changes. So nothing in functionality should be changed.

This PR is the 2nd in a series.

This is a cleanup of the following folders:

/administrator/components/com_categories
/administrator/components/com_checkin
/administrator/components/com_config

administrator/templates/hathor/html/com_categories
administrator/templates/hathor/html/com_checkin
/administrator/templates/hathor/html/com_config

Testing instructions

Check if all the views of these components still function as expected.

PR Series

  1. Code style / syntax cleanup #1 #1395
  2. Code style / syntax cleanup #2 #1403

@ghost ghost mentioned this pull request Jul 3, 2013
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two lines are OK using inline conditionals. Our layout files have selective enforcement of many of the PHPCS rules due to the mixed HTML/PHP nature which causes a lot of false failures otherwise.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed inline if syntax from:
if ($listDirn == 'asc') echo 'selected="selected"';
to:
echo $listDirn == 'asc' ? ' selected="selected"' : '';

@ghost ghost deleted the syntax_2 branch July 7, 2013 22:50
@ghost ghost mentioned this pull request Jul 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant