[com_fields] Responsive subform.repeatable-table#13769
Merged
rdeutz merged 5 commits intojoomla:stagingfrom Jan 27, 2017
Merged
[com_fields] Responsive subform.repeatable-table#13769rdeutz merged 5 commits intojoomla:stagingfrom
rdeutz merged 5 commits intojoomla:stagingfrom
Conversation
|
I have tested this item ✅ successfully on 6527898 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769. |
Member
|
I have tested this item ✅ successfully on 6527898 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769. |
Member
|
I think it would be a new PR, but can this being applied for all tables to make them responsive? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769. |
Contributor
Author
|
Yes.. there would be no real problem there. All that is required is that the title is added to a data attribute for each td (layouts/joomla/form/field/subform/repeatable-table/section.php). For some tables there may be to much data to display every column in the row view. Would need to decide what rows to show and what rows to leave out for each table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR makes subform tables responsive, switching from column to row views on smaller screens. This form is used in com_fields however applies to all subform tables
Testing Instructions
Navigate to Content -> Fields -> New. Set 'Type' to 'Checkbox', add a number of values and resize the browser window.
@laoneo This resolves the issue we discussed at the sprint regarding using subform.repeatable-table and smaller screens.
Before Patch
After Patch
Documentation Changes Required
None