Implemented pausing mechanisms into cli/finder_indexer.php.#13502
Implemented pausing mechanisms into cli/finder_indexer.php.#13502HLeithner merged 21 commits intojoomla:stagingfrom frankmayer:cli-finder-indexer
Conversation
The reason for that is, that with thousands of articles or K2 items, the server would often become unresponsive, because of a lot of processing and IO/WAiT on the mysql server. This patch implements a pausing mechanism that pauses for a defined or dynamically adjusted amount of time between batches, therefore giving the server a little time to catch up.
- type safe comparison of empty string
|
I have tested this item ✅ successfully on b7134e2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13502. |
|
Thank you for this feature. I do consider it a new feature and not just a bugfix, and thus I would recommend to add this to 4.0 instead of 3.x. I would actually be interested if this issue persists with the new DB structure in 4.0. And yes, some things take a VERY long time. sigh |
|
@Hackwar Yes, it can be seen both ways. But it fixes a problem that is happening on the 3.x version. And since people will be on that version for some time to come, we might as well provide a better experience. As for 4.0, I have not tested, and unfortunately I didn't have any time to check out all the great stuff you people have done with the new version. But if we have this on 3.x it shouldn't be too much of an effort, if needed, to port it to 4.0. |
# Conflicts: # cli/finder_indexer.php
|
@franz-wohlkoenig resolved conflicts. |
- Set correct default for class property.
…run through the pausing part, if we don't want to pause.
- Changes in script documentation
|
I have tested this item ✅ successfully on 9b4cd19 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13502. |
|
@Quy can you please retest? |
|
I have tested this item ✅ successfully on 9b4cd19 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13502. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13502. |
|
Thanks for this PR. The reason I'm merging this into 3.9 series is to protect servers overloading. |
New issue:
With thousands of articles or K2 items with lots of different text each, the server might become unresponsive, mostly as a result of a lot of processing and IO/WAIT.
Summary of Changes
This patch implements a pausing mechanism that pauses for a defined or dynamically adjusted amount of time between batches, therefore giving the server a little time to catch up.
Testing Instructions
Note:
For all of the tests, you may break the processing, at any point, after the findings are confirmed. No need to run them completely on very large sets of data.
--purgeparameter to also clean up the database.Note: You might or might not notice (on huge number of articles with a lot of different text) that the machine(server) might get unresponsive.
Even if you don't notice that, you will notice that the apache/php- and mysql-processes are each constantly fully consuming a CPU core. Which depending on the cores available (and the settings of mysql in core usage) might translate to 50% on a dual core, 25% on a quad core or 12,5% on an octa-core processor. While this alone might not be an issue, it does add up the the problem at hand.
You also might or might not notice (depending on the storage subsystem [hdd, ssd or hybrid]) that there is a lot of IO/WAIT during the task. It gets worse, if it is a very long running task. I have seen this resulting in an unresponsive site, during indexing. Where unresponsive can mean that the response could take from 5-10 seconds to a lot more, or a complete timeout.
--purgeargument).You should notice pauses being inserted between each batch, according to the time the finished batch took to process. The division to determine the pause length is rounded[processed-batch-running-time / divisor]. The default divisor is 5.
You should also notice that the site/admin interface is now a lot more responsive, as the machine has less IO/WAITS and less constantly fully consuming of CPU cores.
Now run the same command again (with the
--purgeargument), and add--pause=division --divisor=3Notice that the pauses are correctly calculated using the new divisor.
Now run the same command again (with the
--purgeargument), and replace the--pause=division --divisor=3with--pause=3Notice that the pauses are constantly three seconds long.
Documentation Changes Required
Yes. The new arguments should be included in the documentation here: https://docs.joomla.org/Setting_up_automatic_Smart_Search_indexing