Load system plugins in Smart Search indexer #13358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I have tested this item ✅ successfully on 7e0794b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13358. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 7e0794b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13358. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13358. |
joomla-cms-bot
added
PR-staging
and removed
RTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #13338 the Smart Search CLI indexer does not load the system plugins so event handlers not in "finder" plugins will not be called. This PR loads the system plugins as well as the finder plugins.
Summary of Changes
Loads system plugins. Also defines the JDEBUG constant which was causing some spurious warning messages.
Testing Instructions
Testing would require creating a system plugin containing a finder event handler. I doubt anyone will go to that much trouble so I suggest this can be simply merged on review.
Documentation Changes Required
None.