Skip to content

Conversation

@Bakual
Copy link
Contributor

@Bakual Bakual commented Dec 15, 2016

As reported by @brianteeman if you enabled language debuggin, you will get a fatal error when trying to edit an article in backend.
This is because the getLayoutData method is run both for the getInput and getLabel methods and thus the value is processed twice. Now the first round works fine and leaves the value as **2016-12-15**, but the second round PHP can't work with that value anymore because it's no longer a valid date string.

Summary of Changes

This PR moves the value processing from the getLayoutData method to the getInput one so it is only run once.

Testing Instructions

  • Enable language debugging and edit an article in backend. See that the error occurs. (Form looks broken and there is a funny browser title).
  • Apply PR and the form works again.
  • Make sure the date eg in "Publish Up" is as expected, also taking also into account timezone settings.
  • Make sure the translate dateformat works. You need to add language strings to your second language as explained in TranslateFormat in all other forms #13158 (when you're at it, test that one as well :smile)

Documentation Changes Required

None

@infograf768
Copy link
Member

infograf768 commented Dec 17, 2016

I have tested this item ✅ successfully on 4826e6d

Works fine here.

screen shot 2016-12-17 at 11 40 18


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13233.

@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on 4826e6d

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13233.

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13233.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 18, 2016
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Dec 18, 2016
@rdeutz rdeutz merged commit 82faaae into joomla:staging Dec 18, 2016
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Dec 18, 2016
@Bakual Bakual deleted the FixDoubleProcessing branch December 18, 2016 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants