[#31203] The one way and the one container for store the script options#1319
Closed
Fedik wants to merge 9 commits intojoomla:masterfrom
Closed
[#31203] The one way and the one container for store the script options#1319Fedik wants to merge 9 commits intojoomla:masterfrom
Fedik wants to merge 9 commits intojoomla:masterfrom
Conversation
Fedik
added a commit
to Fedik/joomla-cms
that referenced
this pull request
Jun 22, 2013
Member
Author
|
nice tip, need to try... about JSON_FORCE_OBJECT I think it no need cause it convert the non-associative array to object that not really nice in case when you need to have the array in the options |
Contributor
|
I meant you're missing P: Your are right about JSON_FORCE_OBJECT. I just copied that from my code :) |
Member
Author
|
ah hahaha |
Member
Author
|
pull to staging #3072 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current state the developers add the script options as global variables via addScriptDeclaration, that can be not always safe, and not nice. This path allow to store options in the one global object, where the options separated by the extension name.
The options stays as array until header render, that allow to simple overwrite it if need.
Example add the script option:
Access to the options in frontend:
Links: