Simplify ternary with elvis in site component #13185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 414f378 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13185. |
|
I have tested this item ✅ successfully on 414f378 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13185. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13185. |
…nent # Conflicts: # components/com_config/model/cms.php # components/com_content/views/archive/tmpl/default_items.php # components/com_content/views/article/tmpl/default_links.php
|
Conflicts resolved. Could you pls review and merge if OK? |
andrepereiradasilva
approved these changes
Dec 14, 2016
matrikular
reviewed
Dec 18, 2016
| } | ||
|
|
||
| $method = $input->get('method') ? $input->get('method') : 'get'; | ||
| $method = $input->get('method') ?: 'get'; |
There was a problem hiding this comment.
Just wanted to point out that there is no need for a ternary / elvis operator here at all. The method should be retrieved / set via the second parameter (default) that can be passed to the get method of JInput.
get(string $name, mixed $default = null, string $filter = 'cmd') : mixed
I would do a PR for that, if there are no objections.
There was a problem hiding this comment.
@matrikular Of course 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR is part of a set to try to separate some of the changes done in some of my previous batch PR's for site/components, which are still on hold (#12290, #12292, #12293, #12294).
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.