Remove never needed nor used JED Update Server from new installs

[zero-24]

Summary of Changes

Following Michaels tip: #13041 (comment)

we should just delete that never used JED channel already)

Remove never needed nor used JED Update Server from new installs

Testing Instructions

• Install staging.
• go to the update sites view
• check theat the Joomla! Extension Directory entry is there
• install this branch: https://github.com/zero-24/joomla-cms/archive/remove_jedUpdateserv.zip
• check that this update server is not there.

Documentation Changes Required

None as it was never used.

see: joomla/update.joomla.org#31

[alikon]

should be 4 the next available sequence id ;)

[andrepereiradasilva]

shouldn't be deleted also on update?
something like this?

DELETE FROM `#__updates`
WHERE `update_site_id` = (SELECT `update_site_id` FROM `#__update_sites` WHERE `name` = 'Joomla! Extension Directory' AND `type` = 'collection');

DELETE FROM `#__update_sites_extensions`
WHERE `update_site_id` = (SELECT `update_site_id` FROM `#__update_sites` WHERE `name` = 'Joomla! Extension Directory' AND `type` = 'collection');

DELETE FROM `#__update_sites`
WHERE `name` = 'Joomla! Extension Directory' AND `type` = 'collection';

[alikon]

is only for new install

[andrepereiradasilva]

also you need to remove them from:

• https://github.com/joomla/joomla-cms/blob/staging/administrator/manifests/files/joomla.xml#L51
• https://github.com/joomla/joomla-cms/blob/staging/tests/unit/stubs/database/jos_update_sites.csv
• https://github.com/joomla/joomla-cms/blob/staging/tests/unit/stubs/database/jos_update_sites_extensions.csv

[andrepereiradasilva]

is only for new install

Why?

[alikon]

looking at https://update.joomla.org/jed/list.xml

<extensionset name="JED" description="Joomla! Extension Directory">
<!--  TODO: fill this out  -->
</extensionset>

don't know why

[andrepereiradasilva]

@alikon what i mean is this update sites in all current joomla installs, so should be removed on updated too IMHO.

[zero-24]

Thanks. I can fix this later. I have also missed one place to remove that link ;) in the xml. The update part will be done via php as i have no idea how postgres or mssql works with sub querys ;)

[alikon]

I have tested this item ✅ successfully on fa48100

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13047.}

[andrepereiradasilva]

misses __DEPLOY_VERSION__

[andrepereiradasilva]

not essencial, but why only quoteName the database table and not the db fields?

[andrepereiradasilva]

shoudn't the ids be changed here too?

[zero-24]

should be good now @andrepereiradasilva

[brianteeman]

I have tested this item ✅ successfully on 830681f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13047.}

[alikon]

I have tested this item ✅ successfully on 830681f

on code review

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13047.}

[jeckodevelopment]

I have tested this item ✅ successfully on 830681f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13047.}

[jeckodevelopment]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13047.}