Skip to content

Conversation

@ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Aug 25, 2016

Pull Request for Issue #11765 .

Summary of Changes

Strangely the issue appears to be related to the 'user' field (Publishing tab), specifically a hidden cancel button which is rendered from an override in the Isis template. Removing the 'cancel' text resolves the issue however this points to the correct solution been elsewhere. Anyone more familiar with the Isis template I suspect would have a better solution?

Testing Instructions

  1. Create a new article
  2. Add an article title
  3. Click the alias field (or any text field), add text (or not).
  4. Hit 'enter' key

Before patch
Article is cancelled, navigating back to article manager.

After patch
Nothing

Pull Request for Issue #11765

Removing the 'cancel' text resolves the issue however this points to the correct solution been elsewhere. Anyone more familiar with the Isis template I suspect would have a better solution?
@brianteeman
Copy link
Contributor

@DGT41 could you take a look at this please

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 243f84b

I applied the patch but I dont see any changed behaviour


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11782.

@C-Lodder
Copy link
Member

This PR doesn't do what is intended at all. All you've done is removed the text (Cancel) from the modal footer button, resulting in an empty button, as shown below:

screeny

@C-Lodder
Copy link
Member

If you want to prevent the enter button from triggering the redirect, then you're going to have to go with a Javascript approach. Bare in mind that this occurs on most other components, not just com_content

@dgrammatiko
Copy link
Contributor

@brianteeman @C-Lodder a simple exchange of the <button> to a <a> solves this problem. @ciar4n can you make this change?

@dgrammatiko
Copy link
Contributor

@brianteeman @C-Lodder @ciar4n check #11787

@brianteeman
Copy link
Contributor

I am closing in favour of 11787


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11782.

@ciar4n ciar4n deleted the patch-2 branch August 25, 2016 13:20
@ciar4n ciar4n restored the patch-2 branch August 25, 2016 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants