Skip to content

Conversation

@photodude
Copy link
Contributor

@photodude photodude commented Aug 21, 2016

Pull Request for Simplify Travis CI testing by only using mysql root .

Summary of Changes

Simplify Travis CI testing by only using mysql root

This eliminates the HHVM and non-HHVM specific mysql database creations. By using only the root option we have a simpler testing setup.

Testing Instructions

merge by code review

Documentation Changes Required

none

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 8754ce0

seems logic to me.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11703.

@photodude
Copy link
Contributor Author

photodude commented Aug 23, 2016

@rdeutz, @mbabker, @wilsonge, can this get a bump for merge consideration

@rdeutz
Copy link
Contributor

rdeutz commented Aug 24, 2016

I have tested this item ✅ successfully on 8754ce0


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11703.

@rdeutz
Copy link
Contributor

rdeutz commented Aug 24, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11703.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2016
@rdeutz rdeutz added this to the Joomla 3.6.3 milestone Aug 24, 2016
@yvesh
Copy link
Member

yvesh commented Aug 24, 2016

@photodude how about moving that create database into the sql file? That would simplify it even more ;)

@mbabker
Copy link
Contributor

mbabker commented Aug 24, 2016

👎 the SQL file is used for more than Travis and the database name is configurable via the DSN strings for each instance.

@rdeutz
Copy link
Contributor

rdeutz commented Aug 25, 2016

set to needs review for double checking the patch


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11703.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 25, 2016
@photodude
Copy link
Contributor Author

@rdeutz I'm not sure I'm following, what needs to be reviewed with the patch?

@rdeutz
Copy link
Contributor

rdeutz commented Aug 26, 2016

@photodude the comment @mbabker makes me wonder if this the right thing to do, so I removed RTC to make sure it doesn't gets merged by accident and give me some time to check again.

@mbabker
Copy link
Contributor

mbabker commented Aug 26, 2016

My comment was in response to @yvesh suggesting the CREATE DATABASE statement be moved into the SQL files, not the root user change.

@rdeutz
Copy link
Contributor

rdeutz commented Aug 26, 2016

Ah, thought better look twice than sorry :-) So we can merge this.

@rdeutz rdeutz merged commit c15e7a8 into joomla:staging Aug 26, 2016
@photodude
Copy link
Contributor Author

Thanks @rdeutz

@photodude photodude deleted the patch-10 branch August 26, 2016 13:50
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
…areable-draft-content

* origin/shareable-draft-content: (245 commits)
  Implement shareable draft links
  Cleaned up shared drafts view Added front-end token generarion
  Implement shared drafts view
  Remove obsolete file
  use only root (joomla#11703)
  com_search category results not displaying date (joomla#11802)
  warnings and errors, not notices ... (joomla#11801)
  [installation] Add javascript message titles and ajax errors strings (joomla#11800)
  Regression: Normalising head links and correcting hreflang for menu items associations (joomla#11769)
  Refactor allowEdit of backend category controller (joomla#11547)
  [com_contact] Move event trigger to correct place (joomla#11719)
  Improve the accessibility of the top menu in ISIS part 2 (joomla#11729)
  Show file extension (joomla#11776)
  change button -> a for the modal close button (joomla#11787)
  Small Grammar change (joomla#11788)
  Change message type to error when download of update package fails (joomla#11791)
  these are warnings not messages ... (joomla#11799)
  [plg_content_vote|pagebreak] Load language files only when needed (joomla#11730)
  [plg_system_stats] Load plugin language files only when needed (joomla#11728)
  Fix creation performance of form element menuparent, (slow down in menu item edit form, for item that belongs to large menu) (joomla#11628)
  ...

# Conflicts:
#	administrator/components/com_admin/script.php
#	administrator/components/com_content/models/shared.php
#	administrator/components/com_content/views/shared/tmpl/default.php
#	administrator/language/en-GB/en-GB.xml
#	administrator/language/en-GB/install.xml
#	administrator/manifests/files/joomla.xml
#	administrator/manifests/packages/pkg_en-GB.xml
#	installation/language/en-GB/en-GB.xml
#	language/en-GB/en-GB.xml
#	language/en-GB/install.xml
#	libraries/cms/pagination/pagination.php
#	libraries/cms/version/version.php
#	libraries/joomla/authentication/authentication.php
#	libraries/joomla/form/fields/color.php
#	libraries/joomla/form/fields/email.php
#	media/system/js/share-uncompressed.js
#	media/system/js/share.js
#	plugins/content/vote/vote.php
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
…areable-draft-content

* origin/shareable-draft-content: (253 commits)
  Fixed conflict
  Added menu item
  Code cleanup
  Implement shareable draft links
  Cleaned up shared drafts view Added front-end token generarion
  Implement shared drafts view
  Remove obsolete file
  use only root (joomla#11703)
  com_search category results not displaying date (joomla#11802)
  warnings and errors, not notices ... (joomla#11801)
  [installation] Add javascript message titles and ajax errors strings (joomla#11800)
  Regression: Normalising head links and correcting hreflang for menu items associations (joomla#11769)
  Refactor allowEdit of backend category controller (joomla#11547)
  [com_contact] Move event trigger to correct place (joomla#11719)
  Improve the accessibility of the top menu in ISIS part 2 (joomla#11729)
  Show file extension (joomla#11776)
  change button -> a for the modal close button (joomla#11787)
  Small Grammar change (joomla#11788)
  Change message type to error when download of update package fails (joomla#11791)
  these are warnings not messages ... (joomla#11799)
  ...

# Conflicts:
#	administrator/components/com_admin/script.php
#	administrator/components/com_content/controllers/article.php
#	administrator/components/com_content/controllers/articles.php
#	administrator/components/com_content/models/forms/article.xml
#	administrator/components/com_content/views/article/view.html.php
#	administrator/components/com_content/views/articles/view.html.php
#	components/com_content/views/form/tmpl/edit.php
#	libraries/cms/pagination/pagination.php
#	libraries/joomla/form/fields/email.php
#	plugins/content/vote/vote.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants