Skip to content

Conversation

@andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Aug 17, 2016

Summary of Changes

There is a PHP Notice (check php error logs) when saving a menu as copy a menu item.

Testing Instructions

  1. In multilingual joomla install with associations open any menu item and save as copy. Now check your php log and you will have a php notice there PHP Notice: Undefined index: associations in /path/to/joomla/administrator/components/com_menus/models/item.php on line 1384
  2. Apply patch
  3. Repeat step 1. No PHP Notice

Documentation Changes Required

None

Notes

Found in GsoC multilingual

If this ok will do the same for the other components that have the same issue.

@jreys
Copy link
Contributor

jreys commented Aug 17, 2016

I have tested this item ✅ successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11647.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Aug 17, 2016

I have tested this item ✅ successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11647.

@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on 65fab4a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11647.

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11647.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 17, 2016
@wilsonge wilsonge merged commit 354c1b8 into joomla:staging Aug 17, 2016
@wilsonge wilsonge added this to the Joomla 3.6.3 milestone Aug 17, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 17, 2016
@infograf768
Copy link
Member

Please test #11664

@andrepereiradasilva andrepereiradasilva deleted the patch-17 branch August 19, 2016 10:09
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
* we need isset here to not have a php notice

* Update item.php
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
* we need isset here to not have a php notice

* Update item.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants