Fix performance retrieving menu items in menus helper, e.g. when creating "Select page" filter in modules manager

[ggppdk]

Pull Request for Issue #10997

Fixes performance of creating" Select Page" filter (= menu item filter) in modules manager

Summary of Changes

Removed unused left join, joining menu items table with itself for no reason

No reason because

1. Join is LEFT
2. The results of the join are not used anywhere

• neither in SELECT clause nor WHERE clause and not in any other clause
• There is no PHP code that adds some usage of it under some condition

There is already another (different) self-join for the table on the lft/rgt, similar to the one removed when we limit to a specific parent parent

Testing Instructions

Visit module manager and open search filters, the "Select page" filter should be same as before, and behave as before

Documentation Changes Required

none

[prathumwan]

tested successful, speed is back.

[andrepereiradasilva]

@prathumwan please mark as tested with success in https://issues.joomla.org/tracker/joomla-cms/11627?nocache
Login with github as mark as tested with success

[prathumwan]

I have tested this item ✅ successfully on

search filter for page works, performance is back

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11627.}

[ggppdk]

@prathumwan

also, since you have big set of menu items

besides this PR, also please see PR #11628 that

• fixes performance of menu item FORM

(fixes performance creating menuparent form element, (edit an item that belongs to a large menu)

Go to your largest menu and edit an item there:
then edit it with applying this patch: #11628 , and reply there and not here

[alikon]

I have tested this item ✅ successfully on 7a19975

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11627.}

[ggppdk]

This PR patches the menus helper method: MenusHelper::getMenuLinks()

• so the performance is fixed in all places that use it

That is wherever a menu item select drop is created e.g. "search filter" "select page" in modules manager

and also edit forms that have assignments to menu items

• template edit form
• module edit form

administrator\components\com_modules\views\module\tmpl\edit_assignment.php(14): $menuTypes = MenusHelper::getMenuLinks();
administrator\components\com_templates\views\style\tmpl\edit_assignment.php(14): $menuTypes = MenusHelper::getMenuLinks();
administrator\templates\hathor\html\com_modules\module\edit_assignment.php(14): $menuTypes = MenusHelper::getMenuLinks();
administrator\templates\hathor\html\com_templates\style\edit_assignment.php(14): $menuTypes = MenusHelper::getMenuLinks();
libraries\cms\form\field\menuitem.php(160):         $items = MenusHelper::getMenuLinks($menuType, 0, 0, $this->published, $this->language);

[andrepereiradasilva]

ok so with a small menu (15 menu items) we can still notice the changes:

Before patch

After patch

Note: Code i used for test:

!JDEBUG ?: JProfiler::getInstance('Application')->mark('- start query');
$links = $db->loadObjectList();
!JDEBUG ?: JProfiler::getInstance('Application')->mark('- end query');

[andrepereiradasilva]

I have tested this item ✅ successfully on 7a19975

as comment above

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11627.}

[andrepereiradasilva]

can we have RTC here?

[brianteeman]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11627.}