Remove JTable warning and add a comment #11573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wilsonge merged 2 commits into joomla:staging from andrepereiradasilva:patch-18

Aug 13, 2016

Contributor

andrepereiradasilva commented Aug 12, 2016 •

edited by joomla-cms-bot

Loading

Pull request for issue #11570

Summary of Changes

Removes warning from JTable when table file is not found.
Adds a comment in the code that in 4.0 an Exception will be trown.

Testing Instructions

Add to isis index.php

$table = JTable::getInstance('bla', 'Table', array('dbo' => JFactory::getDbo()));

Check the warning.
Apply patch
Check no warning now

For more info: see #11570

Documentation Changes Required

None


          remove warning

65a6ea7

andrepereiradasilva mentioned this pull request

JTable send warning instead of exception when it doesn't exist #11570

Closed

brianteeman added the PR-staging label

brianteeman reviewed

View reviewed changes

libraries/joomla/table/table.php Outdated

    
              				// If we were unable to find the class file in the JTable include paths, raise a warning and return false.

              				JLog::add(JText::sprintf('JLIB_DATABASE_ERROR_NOT_SUPPORTED_FILE_NOT_FOUND', $type), JLog::WARNING, 'jerror');

              				/*

              				* If we were unable to find the class file in the JTable include paths. Return false.

Contributor

brianteeman Aug 12, 2016

If we are

;)


          corrects comment

27c099f

Contributor

brianteeman commented Aug 12, 2016

I have tested this item ✅ successfully on 65a6ea7

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11573.}

andrepereiradasilva mentioned this pull request

PR waiting core merge joomla-projects/gsoc16_improved-multi-lingual#87

Closed

brianteeman added PR-staging and removed PR-staging labels

Contributor

alikon commented Aug 13, 2016

I have tested this item ✅ successfully on 65a6ea7

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11573.}

Member

infograf768 commented Aug 13, 2016

RTC as 2 good tests

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11573.}

Member

infograf768 commented Aug 13, 2016 •

edited

Loading

hmm RTC bot, please trigger...

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11573.}

Contributor Author

andrepereiradasilva commented Aug 13, 2016

RTC ?

Member

jeckodevelopment commented Aug 13, 2016

I have tested this item ✅ successfully on 27c099f

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11573.}

Member

jeckodevelopment commented Aug 13, 2016

it seems that some of your tests have not been considered properly in JIssue, since I can see only 1 completed test (mine). Setting label manually.

jeckodevelopment added the RTC label

brianteeman added this to the Joomla 3.6.3 milestone

wilsonge merged commit 74ed5b0 into joomla:staging

brianteeman removed the RTC label

andrepereiradasilva deleted the patch-18 branch

August 13, 2016 18:22

ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request


          Remove JTable warning and add a comment (joomla#11573)

dd81b69

* remove warning

* corrects comment

roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request


          Remove JTable warning and add a comment (joomla#11573)

158b1c5

* remove warning

* corrects comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet