Skip to content

Conversation

@andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Jul 20, 2016

Summary of Changes

In backend edit item (article, contact, newsfeed, menu item, etc) layout we can call the page with &tpml=component, but when we submit the form (ex: through javascript in a parent iframe) we go back to the non component (default) template with side bar.

This PR correct that.

Testing Instructions

Code review.

More info

This problem was discovered in GsoC 2016 multilingual project.

@infograf768 @alikon @jreys please test.

@alikon
Copy link
Contributor

alikon commented Jul 20, 2016

I have tested this item ✅ successfully on 872c309


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

1 similar comment
@jreys
Copy link
Contributor

jreys commented Jul 20, 2016

I have tested this item ✅ successfully on 872c309


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

@cyrez
Copy link
Contributor

cyrez commented Jul 20, 2016

Well found! 👍
Maybe to be done in com_modules module edit, where i did the same $tmpl Variable set?

@cyrez
Copy link
Contributor

cyrez commented Jul 20, 2016

I have tested this item ✅ successfully on 872c309


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 872c309

Totally B/C and solves the GSOC issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

@infograf768
Copy link
Member

RTC. Thanks!

@wilsonge

Please merge in 3.6.1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 21, 2016
@infograf768
Copy link
Member

Back to pending. Needs a small correction.

missing

$input = JFactory::getApplication()->input; for menus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 21, 2016
@infograf768
Copy link
Member

@andrepereiradasilva
Please correct

@andrepereiradasilva
Copy link
Contributor Author

andrepereiradasilva commented Jul 21, 2016

corrected menu item issue and added to com_modules. Please retest

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 111fbea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Jul 21, 2016

I have tested this item ✅ successfully on 111fbea


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

@infograf768
Copy link
Member

RTC now for good. :)

@wilsonge

Please merge.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11220.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 21, 2016
@wilsonge wilsonge merged commit a35b149 into joomla:staging Jul 21, 2016
@wilsonge wilsonge added this to the Joomla 3.6.1 milestone Jul 21, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 21, 2016
@andrepereiradasilva andrepereiradasilva deleted the patch-9 branch July 21, 2016 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants