Bootstrap popup with mootools compatibility #2

[dgrammatiko]

This fixes a B/C for form field user

Summary of Changes

Introduce an option that will provide the needed backwards compatibility.

Testing Instructions

Apply patch

• Bootstrap mode
  Test creating a new article and ensure that the field for selecting a user still works.
• Mixed mode
  Edit administrator/components/com_content/views/article/tmpl/edit.php
  and paste the code bellow after line 81 (just before ?>)

JHtml::_('behavior.modal');

$idTag = 'jform_name';

$test_control[] = '<input type="text" disabled id="' .$idTag . '_id" name="' . $idTag . '" value="" style="display: block"/>';

$test_control[] = '<a class="modal btn" title="XXXXX" href="index.php?option=com_users&amp;view=users&amp;layout=modal&amp;tmpl=component&amp;required=1&amp;field=jform_name"'
    . ' rel="{handler: \'iframe\', size: {x: 800, y: 500}}">SELECT MOOTOOLS</a>';

echo implode('', $test_control);

Test again the previous scenario as well as the new button that will appear above the tabs (that's a mootools modal). The field should be filled with the user id selected in the pop up

• Compatibility Mode (AKA Mootools)
  Keep the changes in edit.php
  Rename administrator/templates/isis/html/layouts/joomla/form/field/user.php to xxxuser.php
  Repeat the previous testing steps

[dgrammatiko]

@Fedik can you review this one as well?

[Fedik]

@DGT41 to be honest I am not very understand what is going on here 😄 but I try some test, maybe this evening

[dgrammatiko]

@Fedik onclick event isn't required for bootstrapped version, using the trick to pass a parameter to signify that the modal is bootstrapped we bring B/C even if there are mootools and bootstraped versions of the field in the same page.
Fast forward when joomla will completely remove mootools this parameter even if it exists will be ignored, so also future proof 😉

[Fedik]

I have tested this item ✅ successfully on 4953c0c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.}

[cyrez]

In compatibility mode (with override removed from Isis, and so in mootools modal) the no-user is broken (but it was a "not" visible issue before excepted when tested B/C after layout removal).
I fix this here : https://github.com/joomla/joomla-cms/pull/10772/files#diff-8369fe928ed3e29986d8f380ed245ef2R52 (missing window.parent.jSelectUser(this) on click for no user button)

Another issue (but was there before, so not due to your PR, but could be fixed in the same time) : in all testing cases, if you select no user, you will have the text "Select a user." as the field user name value, where it should be just a placeholder.
But this needs i think, to add this in fielduser.js to set placeholder, and set name as empty.

About your code, after tests all seems good! 👍

[joomla-cms-bot]

This PR has received new commits.

CC: @Fedik

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.}

[dgrammatiko]

@JoomliC I've fixed the No-User button

[cyrez]

@DGT41 Confirm that no user button is fixed. 👍
What about the field name value on "no user" click ? To have a placeholder instead ?

[joomla-cms-bot]

This PR has received new commits.

CC: @Fedik

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.}

[rahultailored]

I have tested this item ✅ successfully on a337e9b

Tested Successfully in Joomla! 3.6.0-rc.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.}

[gautamtailored]

I have tested this item ✅ successfully on a337e9b

Successfully Tested.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.}

[gunjanpatel]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10791.}